test(react-swc): simplify ts-lib test #548
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hi-ogawa
changed the title
ArnaudBarre
reviewed
Jul 8, 2025
| "dependencies": { | ||
| "@generouted/react-router": "^1.20.0", | ||
| "generouted": "1.11.7", | ||
| "@vitejs/test-dep-non-js": "file:./test-dep/non-js", |
There was a problem hiding this comment.
I don't think this as the same behaviour as being in node_modules because node_modules is not in the resolved path
There was a problem hiding this comment.
file:./ doesn't create a symlink, so the scenario should be same. I also confirmed manually adding back if (id.includes("node_modules")) return; indeed broke the tests.
ArnaudBarre
approved these changes
Jul 8, 2025
| "dependencies": { | ||
| "@generouted/react-router": "^1.20.0", | ||
| "generouted": "1.11.7", | ||
| "@vitejs/test-dep-non-js": "file:./test-dep/non-js", |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
I simplified a test case which was added for testing tsx files inside
node_modules4b9b2d5 since needing to pin old versions ofgeneroutedfor this purpose is not good.