Skip to content

Commit 55e691c

Browse files
committed
chore: only apply commit convention to PR titles
ref: vitejs/vite#11296
1 parent 06dda5a commit 55e691c

File tree

6 files changed

+8
-140
lines changed

6 files changed

+8
-140
lines changed

.github/PULL_REQUEST_TEMPLATE.md

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -20,7 +20,7 @@
2020
### Before submitting the PR, please make sure you do the following
2121

2222
- [ ] Read the [Contributing Guidelines](https://github.com/vitejs/vite/blob/main/CONTRIBUTING.md).
23-
- [ ] Read the [Pull Request Guidelines](https://github.com/vitejs/vite/blob/main/CONTRIBUTING.md#pull-request-guidelines) and follow the [Commit Convention](https://github.com/vitejs/vite-plugin-vue/blob/main/.github/commit-convention.md).
23+
- [ ] Read the [Pull Request Guidelines](https://github.com/vitejs/vite/blob/main/CONTRIBUTING.md#pull-request-guidelines) and follow the [PR Title Convention](https://github.com/vitejs/vite/blob/main/.github/commit-convention.md).
2424
- [ ] Check that there isn't already a PR that solves the problem the same way to avoid creating a duplicate.
2525
- [ ] Provide a description in this PR that addresses **what** the PR is solving, or reference the issue that it solves (e.g. `fixes #123`).
2626
- [ ] Ideally, include relevant tests that fail without this PR but pass with it.

.github/commit-convention.md

Lines changed: 0 additions & 92 deletions
This file was deleted.

.github/semantic.yml

Lines changed: 0 additions & 17 deletions
This file was deleted.

.github/workflows/semantic-pull-request.yml

Lines changed: 6 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -15,5 +15,11 @@ jobs:
1515
steps:
1616
- name: Validate PR title
1717
uses: amannn/action-semantic-pull-request@v5
18+
with:
19+
subjectPattern: ^(?![A-Z]).+$
20+
subjectPatternError: |
21+
The subject "{subject}" found in the pull request title "{title}"
22+
didn't match the configured pattern. Please ensure that the subject
23+
doesn't start with an uppercase character.
1824
env:
1925
GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }}

package.json

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -73,8 +73,7 @@
7373
"vue": "^3.3.4"
7474
},
7575
"simple-git-hooks": {
76-
"pre-commit": "pnpm exec lint-staged --concurrent false",
77-
"commit-msg": "pnpm exec tsx scripts/verifyCommit.ts $1"
76+
"pre-commit": "pnpm exec lint-staged --concurrent false"
7877
},
7978
"lint-staged": {
8079
"*": [

scripts/verifyCommit.ts

Lines changed: 0 additions & 28 deletions
This file was deleted.

0 commit comments

Comments
 (0)