Import attributes are not passed to `resolveId` if dynamic import regex matches

[edoardocavazza]

Describe the bug

I am authoring a plugin for constructable CSS modules but I've encountered this problem with sources that include dynamic imports (even when part of a comment). In this case, Vite doesn't pass the attributes to the resolveId hook.

Reproduction

https://stackblitz.com/edit/stackblitz-starters-e5w5q9xi?file=src%2Fdynamic.js

Steps to reproduce

• Run npm install
• Run node index.js
• The run fails.
• Remove both comments in the dynamic.js file
• Run node index.js again
• The run succeed.

System Info

System:
    OS: Linux 5.0 undefined
    CPU: (8) x64 Intel(R) Core(TM) i9-9880H CPU @ 2.30GHz
    Memory: 0 Bytes / 0 Bytes
    Shell: 1.0 - /bin/jsh
  Binaries:
    Node: 20.19.1 - /usr/local/bin/node
    Yarn: 1.22.19 - /usr/local/bin/yarn
    npm: 10.8.2 - /usr/local/bin/npm
    pnpm: 8.15.6 - /usr/local/bin/pnpm
  npmPackages:
    @rollup/wasm-node:  4.55.1 
    vite: ^7.3.1 => 7.3.1

Used Package Manager

npm

Logs

No response

Validations

• Follow our Code of Conduct
• Read the Contributing Guidelines.
• Read the docs.
• Check that there isn't already an issue that reports the same bug to avoid creating a duplicate.
• Make sure this is a Vite issue and not a framework-specific issue. For example, if it's a Vue SFC related bug, it should likely be reported to vuejs/core instead.
• Check that this is a concrete bug. For Q&A open a GitHub Discussion or join our Discord Chat Server.
• The provided reproduction is a minimal reproducible example of the bug.

[edoardocavazza]

I think I found the "culprit":

vite/packages/vite/src/node/plugins/importAnalysisBuild.ts

Line 338 in a3de203

// strip import attributes as we can process them ourselves

I'm not sure why the attributes are being removed here.