refactor: Require rule name in createTestingLibraryRule return type and use rule.name in tests (#860)

* deps: update typescript-eslint related packages

* refactor: update rule imports to use rule.name instead of RULE_NAME

* refactor: remove export of RULE_NAME

* refactor: use RULE_NAME constant for rule name in prefer-expect-assertions

Author: y-hsgw

package.json

@@ -41,15 +41,15 @@
     "update:eslint-docs": "pnpm build && eslint-doc-generator"
   },
   "dependencies": {
-    "@typescript-eslint/scope-manager": "^8.46.1",
-    "@typescript-eslint/utils": "^8.46.1"
+    "@typescript-eslint/scope-manager": "^8.51.0",
+    "@typescript-eslint/utils": "^8.51.0"
   },
   "devDependencies": {
     "@eslint/js": "^9.38.0",
     "@types/eslint": "^9.6.1",
     "@types/node": "^22.18.10",
-    "@typescript-eslint/parser": "^8.46.1",
-    "@typescript-eslint/rule-tester": "^8.46.1",
+    "@typescript-eslint/parser": "^8.51.0",
+    "@typescript-eslint/rule-tester": "^8.51.0",
     "bumpp": "^10.3.1",
     "concurrently": "^9.2.1",
     "eslint": "^9.37.0",
@@ -64,7 +64,7 @@
     "tsdown": "^0.15.10",
     "tsx": "^4.20.6",
     "typescript": "^5.9.3",
-    "typescript-eslint": "^8.46.1",
+    "typescript-eslint": "^8.51.0",
     "vitest": "^3.2.4"
   },
   "peerDependencies": {

pnpm-lock.yaml

@@ -2,7 +2,7 @@ import { TSESTree } from '@typescript-eslint/utils'
 import { createEslintRule, getAccessorValue } from '../utils'
 import { parseVitestFnCall } from '../utils/parse-vitest-fn-call'
 
-export const RULE_NAME = 'consistent-each-for'
+const RULE_NAME = 'consistent-each-for'
 export type MessageIds = 'consistentMethod'
 
 type EachOrFor = 'each' | 'for'

src/rules/consistent-each-for.ts

@@ -1,6 +1,6 @@
 import { createEslintRule } from '../utils'
 
-export const RULE_NAME = 'consistent-test-filename'
+const RULE_NAME = 'consistent-test-filename'
 
 const defaultPattern = /.*\.test\.[tj]sx?$/
 const defaultTestsPattern = /.*\.(test|spec)\.[tj]sx?$/

src/rules/consistent-test-filename.ts

@@ -6,7 +6,7 @@ import {
 } from '../utils/parse-vitest-fn-call'
 import { TestCaseName } from '../utils/types'
 
-export const RULE_NAME = 'consistent-test-it'
+const RULE_NAME = 'consistent-test-it'
 export type MessageIds = 'consistentMethod' | 'consistentMethodWithinDescribe'
 
 const buildFixer =

src/rules/consistent-test-it.ts

@@ -3,7 +3,7 @@ import { createEslintRule, isSupportedAccessor } from '../utils'
 import { UtilName } from '../utils/types'
 import { parseVitestFnCall } from '../utils/parse-vitest-fn-call'
 
-export const RULE_NAME = 'consistent-vitest-vi'
+const RULE_NAME = 'consistent-vitest-vi'
 export type MESSAGE_ID = 'consistentUtil'
 
 const getOppositeVitestUtilKeyword = (util: UtilName) =>

src/rules/consistent-vitest-vi.ts

@@ -6,7 +6,7 @@ import {
   isTypeOfVitestFnCall,
 } from '../utils/parse-vitest-fn-call'
 
-export const RULE_NAME = 'expect-expect'
+const RULE_NAME = 'expect-expect'
 export type MESSAGE_ID = 'noAssertions'
 type Options = [
   {

src/rules/expect-expect.ts

@@ -1,7 +1,7 @@
 import { AST_NODE_TYPES, TSESLint, TSESTree } from '@typescript-eslint/utils'
 import { createEslintRule } from '../utils'
 
-export const RULE_NAME = 'hoisted-apis-on-top'
+const RULE_NAME = 'hoisted-apis-on-top'
 
 type MESSAGE_ID =
   | 'hoistedApisOnTop'

src/rules/hoisted-apis-on-top.ts

@@ -5,7 +5,7 @@ import {
   parseVitestFnCall,
 } from '../utils/parse-vitest-fn-call'
 
-export const RULE_NAME = 'max-expects'
+const RULE_NAME = 'max-expects'
 export type MESSAGE_ID = 'maxExpect'
 export type Options = [
   {

src/rules/max-expects.ts

@@ -1,7 +1,7 @@
 import { TSESTree } from '@typescript-eslint/utils'
 import { createEslintRule } from '../utils'
 
-export const RULE_NAME = 'max-nested-describe'
+const RULE_NAME = 'max-nested-describe'
 export type MESSAGE_ID = 'maxNestedDescribe'
 export type Options = [
   {