Merge branch 'main' into fix/top-level-bench-duplicate-output

Author: restareaByWeezy

.claude/skills/typo-checker/SKILL.md

@@ -0,0 +1,100 @@
+---
+name: typo-checker
+description: >
+  Run typos-cli on the codebase, review findings, fix real typos, and update
+  _typos.toml config to suppress false positives. Use this skill for routine
+  codebase typo maintenance. Invoke when doing periodic codebase hygiene,
+  when the user mentions typos or spelling checks, or as a scheduled
+  maintenance task.
+---
+
+# Typo Checker
+
+Scan the codebase with `typos-cli`, classify findings, fix real typos, and maintain `_typos.toml` so false positives don't recur.
+
+## Prerequisites
+
+`typos-cli` must be installed. If not available, install via one of:
+
+| Method | Command |
+|---|---|
+| cargo | `cargo install typos-cli` |
+| brew | `brew install typos-cli` |
+| pipx | `pipx install typos` |
+| Binary | Download from https://github.com/crate-ci/typos/releases |
+
+## Workflow
+
+### 1. Scan
+
+```bash
+typos --format=brief
+```
+
+This outputs one finding per line: `file:line:col: \`typo\` -> \`suggestion\``. Compact and easy to parse.
+
+`typos` respects `.gitignore` by default, so `node_modules/`, `dist/`, build outputs are already excluded.
+
+To get an overview first:
+
+```bash
+# Count unique typo words by frequency
+typos --format=brief 2>&1 | sed "s/.*\`//;s/\`.*//" | sort | uniq -c | sort -rn | head -20
+```
+
+If many findings come from minified/generated files, add those paths to `_typos.toml` `extend-exclude` first, then re-scan.
+
+### 2. Classify each finding
+
+For every finding, decide:
+
+- **Real typo** — fix it
+- **False positive** — add to `_typos.toml`
+
+Common false positive patterns:
+- Short variable names that happen to be words (`ba`, `fo`, `nd`)
+- Domain abbreviations (`als` for AsyncLocalStorage, `PnP` for Plug'n'Play)
+- File extensions in regexes (`.styl`, `.pcss`)
+- Test fixture strings and test data
+- Line truncation artifacts in inline snapshots (`afte...`, `wrapp...`)
+- Product names and proper nouns
+- Lorem ipsum text
+
+When in doubt about whether a misspelled variable name is "intentional" — it's still a typo. Propagated typos are still typos. Fix them.
+
+### 3. Fix real typos
+
+- **Comments, docs, JSDoc**: fix the text directly
+- **Variable/property names**: rename all occurrences consistently
+- **Test names**: fix the name, update corresponding snapshot files
+- **Filenames**: rename the file and update all imports/references — check for references before renaming
+
+### 4. Update `_typos.toml`
+
+Add false positives to `[default.extend-words]` with a comment explaining why:
+
+```toml
+[default.extend-words]
+# AsyncLocalStorage abbreviation
+als = "als"
+```
+
+For file-level exclusions, use `[files].extend-exclude`:
+
+```toml
+[files]
+extend-exclude = [
+  "*.js.map",
+  "*.svg",
+]
+```
+
+If `_typos.toml` doesn't exist yet, create it.
+
+### 5. Commit
+
+Commit fixes and config updates together:
+
+```
+chore: fix typos and update _typos.toml
+```

_typos.toml

@@ -0,0 +1,32 @@
+[files]
+extend-exclude = [
+  "*.js.map",
+  "*.svg",
+  "test/cli/test/fixtures/reporters/html/**",
+]
+
+[default.extend-words]
+# AsyncLocalStorage abbreviation
+als = "als"
+# Stylus CSS preprocessor extension
+styl = "styl"
+# Yarn Plug'n'Play
+Pn = "Pn"
+PnP = "PnP"
+# Variable prefix pattern (b-a annotation diff)
+ba = "ba"
+# Ordinal suffix
+nd = "nd"
+# Test string with backtick escaping: 'som`e`'
+som = "som"
+# Line truncation artifacts in test output
+afte = "afte"
+wrapp = "wrapp"
+# Test data string
+fo = "fo"
+# Latin lorem ipsum
+optio = "optio"
+# Product name (evalite.dev)
+Evalite = "Evalite"
+# Typo in upstream tinyhighlight LICENSE (TODO: fix upstream)
+Additionaly = "Additionaly"

docs/config/experimental.md

@@ -372,7 +372,7 @@ vi.mock('node:fs', async (importOriginal) => {
 const fs = require('node:fs') // throws an error
 ```
 
-This limitation exists because factories can be asynchronous. This should not be a problem because Vitest doesn't mock builtin modules inside `node_modules`, which is simillar to how Vitest works by default.
+This limitation exists because factories can be asynchronous. This should not be a problem because Vitest doesn't mock builtin modules inside `node_modules`, which is similar to how Vitest works by default.
 
 ### TypeScript
 

examples/opentelemetry/README.md

@@ -9,7 +9,7 @@
 # and serve Web UI at http://localhost:16686
 docker compose up -d
 
-# Run tests (exports with OTLP HTTP by deafult)
+# Run tests (exports with OTLP HTTP by default)
 pnpm test --experimental.openTelemetry.enabled
 
 # Use console exporter for quick debugging

examples/opentelemetry/otel-browser.js

@@ -17,8 +17,8 @@ const provider = new WebTracerProvider({
 provider.register({
   // you can customize contextManager but browser support has limitation
   // cf. https://github.com/open-telemetry/opentelemetry-js/discussions/2060
-  // contextManager: new StackContextManager(), // this is the default (avialable in sdk-trace-web)
-  // contextManager: new ZoneContextManager(), // doesn't seem to help (avialable in @opentelemetry/context-zone)
+  // contextManager: new StackContextManager(), // this is the default (available in sdk-trace-web)
+  // contextManager: new ZoneContextManager(), // doesn't seem to help (available in @opentelemetry/context-zone)
 })
 
 export default provider

packages/browser/context.d.ts

@@ -21,7 +21,7 @@ export { CDPSession };
 
 export interface ScreenshotOptions extends SelectorOptions {
   /**
-   * The HTML element to screeshot.
+   * The HTML element to screenshot.
    */
   element?: Element | Locator
   /**
@@ -905,7 +905,7 @@ export type PrettyDOMOptions = Omit<StringifyOptions, 'maxLength'>
 
 export const utils: {
   /**
-   * This is simillar to calling `page.elementLocator`, but it returns only
+   * This is similar to calling `page.elementLocator`, but it returns only
    * locator selectors.
    */
   getElementLocatorSelectors(element: Element): LocatorSelectors

packages/browser/src/client/public/error-catcher.js

@@ -31,7 +31,7 @@ function catchWindowErrors(errorEvent, prop, cb) {
       cb(e)
     }
     else {
-      // `ErrorEvent` doesn't necessary have `ErrotEvent.error` defined
+      // `ErrorEvent` doesn't necessary have `ErrorEvent.error` defined
       // but some has `ErrorEvent.message` defined, e.g. ResizeObserver error.
       // https://developer.mozilla.org/en-US/docs/Web/API/ErrorEvent/error
       // https://developer.mozilla.org/en-US/docs/Web/API/ResizeObserver#observation_errors

packages/browser/src/client/tester/expect/toMatchScreenshot.ts

@@ -120,5 +120,8 @@ export default async function toMatchScreenshot(
           ]
             .filter(element => element !== null)
             .join('\n'),
+    meta: {
+      outcome: result.outcome,
+    },
   }
 }

packages/browser/src/client/tester/runner.ts

@@ -156,14 +156,16 @@ export function createBrowserRunner(
     }
 
     onTaskFinished = async (task: Task) => {
+      const lastErrorContext = task.result?.errors?.at(-1)?.context
       if (
         this.config.browser.screenshotFailures
         && document.body.clientHeight > 0
         && task.result?.state === 'fail'
         && task.type === 'test'
-        && task.artifacts.every(
-          artifact => artifact.type !== 'internal:toMatchScreenshot',
-        )
+        && !(
+          lastErrorContext
+          && Reflect.get(lastErrorContext, 'assertionName') === 'toMatchScreenshot'
+          && Reflect.get(lastErrorContext, 'meta')?.outcome !== 'unstable-screenshot')
       ) {
         const screenshot = await page.screenshot({
           timeout: this.config.browser.providerOptions?.actionTimeout ?? 5_000,

packages/browser/src/node/commands/screenshotMatcher/index.ts

@@ -273,6 +273,7 @@ function buildOutput(
     case 'unstable-screenshot':
       return {
         pass: false,
+        outcome: outcome.type,
         reference: outcome.reference && {
           path: outcome.reference.path,
           width: outcome.reference.image.metadata.width,
@@ -286,6 +287,7 @@ function buildOutput(
     case 'missing-reference': {
       return {
         pass: false,
+        outcome: outcome.type,
         reference: {
           path: outcome.reference.path,
           width: outcome.reference.image.metadata.width,
@@ -302,11 +304,12 @@ function buildOutput(
     case 'update-reference':
     case 'matched-immediately':
     case 'matched-after-comparison':
-      return { pass: true }
+      return { pass: true, outcome: outcome.type }
 
     case 'mismatch':
       return {
         pass: false,
+        outcome: outcome.type,
         reference: {
           path: outcome.reference.path,
           width: outcome.reference.image.metadata.width,
@@ -333,6 +336,7 @@ function buildOutput(
 
       return {
         pass: false,
+        outcome: null as never,
         actual: null,
         reference: null,
         diff: null,