Stack trace frame filtering docs are slightly wrong, maybe the defaults could be better?

[akaltar]

First of all, I love vitest, thanks for maintaining it!

Based on the docs here:
https://vitest.dev/config/#onstacktrace
It's not obvious that this only applies to errors and not to the printConsoleTrace option. And I'm also not sure if the default option does indeed print an unlimited number of frames, as I can't find anywhere where the stackTraceLimit is being set high enough.

https://vitest.dev/config/#printconsoletrace => this option also doesn't specify that it arbitrarily limits the stack trace in these cases to the default + 6 here:

vitest/packages/vitest/src/runtime/console.ts

Line 152 in 790bc31

const limit = Error.stackTraceLimit

I would think in this case it should uncap it by default?

I wish the docs told me that Error.stackTraceLimit also plays a role.
I also wish that this would be more configurable, maybe even turning on stack traces only for warnings/errors.

I'd be happy to contribute some patches if this is a welcome change

[sheremet-va]

vitest.dev/config#printconsoletrace => this option also doesn't specify that it arbitrarily limits the stack trace in these cases to the default + 6 here:

I think this exists to ensure there is always some stack trace. I am not sure why it is 6 though. (maybe it's the amount of stacks to the actual source?)

Also it actually limits the stack trace to only 6 (the first line is the message):

vitest/packages/vitest/src/runtime/console.ts

Line 155 in 790bc31

const trace = stack?.split('\n').slice(7).join('\n')

I think we can remove this limitation and just always send the full stack.

It's not obvious that this only applies to errors and not to the printConsoleTrace option. And I'm also not sure if the default option does indeed print an unlimited number of frames, as I can't find anywhere where the stackTraceLimit is being set high enough.

The docs are also incorrectly show error: Error instead of error: TestError which is a serialised error, it's never an instance of Error.

I think this function should also apply to the stack printed by printConsoleTrace.

I wish the docs told me that Error.stackTraceLimit also plays a role.

This is kind of expected of Errors, no? We can add this to docs for those who are unaware of Error.stack in V8, though.

[akaltar]

I think we can remove this limitation and just always send the full stack.

I think that would be great

I think this function should also apply to the stack printed by printConsoleTrace.

Should I make a PR?

This is kind of expected of Errors, no? We can add this to docs for those who are unaware of Error.stack in V8, though.

I didn't even know stack traces come from Errors (Eg that there isn't a separate API), let alone that there's a default limit.
I also believe jest + maybe sentry overrides this somewhere by default, as I'm used to seeing super long stack traces without any reference to stackTraceLimit in my code before migrating to vitest. I'm not suggesting a change of the default though, just a small note in the docs

[sheremet-va]

Feel free to make a PR