fix: don't silence reporter errors during --merge-reports#9727
Open
hi-ogawa wants to merge 3 commits intovitest-dev:mainfrom
Open
fix: don't silence reporter errors during --merge-reports#9727hi-ogawa wants to merge 3 commits intovitest-dev:mainfrom
hi-ogawa wants to merge 3 commits intovitest-dev:mainfrom
Conversation
hi-ogawa
changed the title
✅ Deploy Preview for vitest-dev ready!Built without sensitive environment variables
To edit notification comments on pull requests, go to your Netlify project configuration. |
AriPerkkio
approved these changes
Feb 24, 2026
sheremet-va
reviewed
Feb 24, 2026
| await this._testRun.enqueued(project, file).catch(noop) | ||
| await this._testRun.collected(project, [file]).catch(noop) | ||
| await this._testRun.enqueued(project, file) | ||
| await this._testRun.collected(project, [file]) |
Member
There was a problem hiding this comment.
I don’t think the “runtime” ones (triggered by rpc normally) should throw a hard error because they don’t do that in a normal run, I think it should be added to unhandled error instead, maybe we need a test to run in both modes
Contributor
Author
There was a problem hiding this comment.
Good point. Will compare with the normal run behavior.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
--merge-reports#9642Please don't delete this checklist! Before submitting the PR, please make sure you do the following:
pnpm-lock.yamlunless you introduce a new test example.Tests
pnpm test:ci.Documentation
pnpm run docscommand.Changesets
feat:,fix:,perf:,docs:, orchore:.