Skip to content

Commit 3a2d94d

Browse files
authored
feat: change the shellType default to "terminal" (#611)
1 parent c964436 commit 3a2d94d

File tree

15 files changed

+17
-120
lines changed

15 files changed

+17
-120
lines changed

.vscode/launch.json

Lines changed: 10 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -35,6 +35,16 @@
3535
],
3636
"outFiles": ["${workspaceFolder}/dist/**/*.js"]
3737
},
38+
{
39+
"name": "Run Extension Imba Sample",
40+
"type": "extensionHost",
41+
"request": "launch",
42+
"args": [
43+
"--extensionDevelopmentPath=${workspaceFolder}",
44+
"${workspaceFolder}/samples/imba"
45+
],
46+
"outFiles": ["${workspaceFolder}/dist/**/*.js"]
47+
},
3848
{
3949
"name": "Run Extension No Config Sample",
4050
"type": "extensionHost",

.vscode/settings.json

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -15,7 +15,6 @@
1515
"source.organizeImports": "never"
1616
},
1717

18-
"vitest.workspaceConfig": "./vitest.workspace.vscode.ts",
1918
"testing.openTesting": "neverOpen",
2019

2120
// Enable eslint for all supported languages

README.md

Lines changed: 5 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -73,11 +73,11 @@ These options are resolved relative to the [workspace file](https://code.visuals
7373
- `vitest.rootConfig`: The path to your root config file. If you have several Vitest configs, consider using a [Vitest workspace](https://vitest.dev/guide/workspace).
7474
- `vitest.workspaceConfig`: The path to the [Vitest workspace](https://vitest.dev/guide/workspace) config file. You can only have a single workspace config per VSCode workspace.
7575
- `vitest.configSearchPatternExclude`: [Glob pattern](https://code.visualstudio.com/docs/editor/glob-patterns) that should be ignored when this extension looks for config files. Note that this is applied to _config_ files, not test files inside configs. Default: `{**/node_modules/**,**/.*/**,*.d.ts}`. If the extension cannot find Vitest, please open an issue.
76-
- `vitest.shellType`: The method the extension uses to spawn a long-running Vitest process. This is particularly useful if you are using a custom shell script to set up the environment. When using the `terminal` shell type, the websocket connection will be established. Can either be `terminal` or `child_process`. Default: `child process`.
77-
- `vitest.nodeExecutable`: The path to the Node.js executable. If not assigned, tries to find Node.js path via a PATH variable or a `which` command. This is applied only when `vitest.shellType` is `child_process` (the default).
78-
- `vitest.nodeExecArgs`: The arguments to pass to the Node.js executable. This is applied only when `vitest.shellType` is `child_process` (the default).
79-
- `vitest.terminalShellPath`: The path to the shell executable. This is applied only when `vitest.shellType` is `terminal`.
80-
- `vitest.terminalShellArgs`: The arguments to pass to the shell executable. This is applied only when `vitest.shellType` is `terminal`.
76+
- `vitest.shellType`: The method the extension uses to spawn a long-running Vitest process. This is particularly useful if you are using a custom shell script to set up the environment. When using the `terminal` shell type, the websocket connection will be established. Can either be `terminal` or `child_process`. Default: `terminal`.
77+
- `vitest.nodeExecutable`: The path to the Node.js executable. If not assigned, tries to find Node.js path via a PATH variable or a `which` command. This is applied only when `vitest.shellType` is `child_process`.
78+
- `vitest.nodeExecArgs`: The arguments to pass to the Node.js executable. This is applied only when `vitest.shellType` is `child_process`.
79+
- `vitest.terminalShellPath`: The path to the shell executable. This is applied only when `vitest.shellType` is `terminal` (the default).
80+
- `vitest.terminalShellArgs`: The arguments to pass to the shell executable. This is applied only when `vitest.shellType` is `terminal` (the default).
8181
- `vitest.debuggerPort`: Port that the debugger will be attached to. By default uses 9229 or tries to find a free port if it's not available.
8282
- `vitest.debuggerAddress`: TCP/IP address of process to be debugged. Default: localhost
8383
- `vitest.cliArguments`: Additional arguments to pass to the Vitest CLI. Note that some arguments will be ignored: `watch`, `reporter`, `api`, and `ui`. Example: `--mode=staging`

package.json

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -211,7 +211,7 @@
211211
"terminal",
212212
"child_process"
213213
],
214-
"default": "child_process",
214+
"default": "terminal",
215215
"scope": "resource"
216216
},
217217
"vitest.terminalShellPath": {

samples/vite-6/.skip/vitest.config.ts

Lines changed: 0 additions & 1 deletion
This file was deleted.

samples/vite-6/.vscode/settings.json

Lines changed: 0 additions & 9 deletions
This file was deleted.

samples/vite-6/package.json

Lines changed: 0 additions & 15 deletions
This file was deleted.

samples/vite-6/test/fail.test.ts

Lines changed: 0 additions & 5 deletions
This file was deleted.

samples/vite-6/test/mix.test.ts

Lines changed: 0 additions & 9 deletions
This file was deleted.

samples/vite-6/test/pass.test.ts

Lines changed: 0 additions & 5 deletions
This file was deleted.

0 commit comments

Comments
 (0)