Skip to content

Commit 5ade4e7

Browse files
Copilotsheremet-va
andcommitted
Fix type checking and linting issues
Co-authored-by: sheremet-va <[email protected]>
1 parent 0c122a9 commit 5ade4e7

File tree

5 files changed

+61
-3
lines changed

5 files changed

+61
-3
lines changed

packages/extension/src/debug.ts

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -151,6 +151,7 @@ export async function debugTests(
151151
tree,
152152
api,
153153
diagnostic,
154+
undefined, // No inline console log for debug sessions
154155
)
155156
disposables.push(api, runner)
156157

packages/extension/src/inlineConsoleLog.ts

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,6 @@
11
import type { UserConsoleLog } from 'vitest'
22
import * as vscode from 'vscode'
33
import { getConfig } from './config'
4-
import { log } from './log'
54

65
interface ConsoleLogEntry {
76
content: string

packages/extension/src/runner.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,8 +1,8 @@
11
import type { ParsedStack, RunnerTaskResult, TestError } from 'vitest'
22
import type { VitestFolderAPI } from './api'
33
import type { ExtensionDiagnostic } from './diagnostic'
4-
import type { TestTree } from './testTree'
54
import type { InlineConsoleLogManager } from './inlineConsoleLog'
5+
import type { TestTree } from './testTree'
66
import { rm } from 'node:fs/promises'
77
import path from 'node:path'
88
import { inspect, stripVTControlCharacters } from 'node:util'

test/unit/inlineConsoleLog.test.ts

Lines changed: 58 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,58 @@
1+
import type { UserConsoleLog } from 'vitest'
2+
import { expect } from 'chai'
3+
import { InlineConsoleLogManager } from '../../packages/extension/src/inlineConsoleLog'
4+
5+
describe('InlineConsoleLogManager', () => {
6+
it('correctly parses origin with file path', () => {
7+
const manager = new InlineConsoleLogManager()
8+
const log: UserConsoleLog = {
9+
content: 'test message',
10+
origin: '/path/to/file.ts:10:5',
11+
type: 'stdout',
12+
taskId: 'test-id',
13+
time: Date.now(),
14+
size: 12,
15+
}
16+
17+
// @ts-expect-error accessing private method for testing
18+
const result = manager.parseOrigin(log.origin)
19+
20+
expect(result).to.deep.equal({
21+
file: '/path/to/file.ts',
22+
line: 9, // 0-based
23+
})
24+
25+
manager.dispose()
26+
})
27+
28+
it('returns null for invalid origin', () => {
29+
const manager = new InlineConsoleLogManager()
30+
31+
// @ts-expect-error accessing private method for testing
32+
expect(manager.parseOrigin(undefined)).to.be.null
33+
// @ts-expect-error accessing private method for testing
34+
expect(manager.parseOrigin('invalid')).to.be.null
35+
// @ts-expect-error accessing private method for testing
36+
expect(manager.parseOrigin('/path/to/file.ts')).to.be.null
37+
38+
manager.dispose()
39+
})
40+
41+
it('formats content correctly', () => {
42+
const manager = new InlineConsoleLogManager()
43+
44+
// @ts-expect-error accessing private method for testing
45+
expect(manager.formatContent('test\nmessage')).to.equal('test message')
46+
// @ts-expect-error accessing private method for testing
47+
expect(manager.formatContent(' test ')).to.equal('test')
48+
49+
// Long content should be truncated
50+
const longContent = 'a'.repeat(150)
51+
// @ts-expect-error accessing private method for testing
52+
const formatted = manager.formatContent(longContent)
53+
expect(formatted).to.have.lengthOf(103) // 100 + '...'
54+
expect(formatted.endsWith('...')).to.be.true
55+
56+
manager.dispose()
57+
})
58+
})

tsconfig.tsbuildinfo

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1 +1 @@
1-
{"root":["./debug-shims.d.ts","./packages/extension/src/api.ts","./packages/extension/src/config.ts","./packages/extension/src/constants.ts","./packages/extension/src/coverage.ts","./packages/extension/src/debug.ts","./packages/extension/src/diagnostic.ts","./packages/extension/src/extension.ts","./packages/extension/src/log.ts","./packages/extension/src/polyfills.ts","./packages/extension/src/runner.ts","./packages/extension/src/tagsmanager.ts","./packages/extension/src/testtree.ts","./packages/extension/src/testtreedata.ts","./packages/extension/src/utils.ts","./packages/extension/src/watcher.ts","./packages/extension/src/api/child_process.ts","./packages/extension/src/api/pkg.ts","./packages/extension/src/api/resolve.ts","./packages/extension/src/api/rpc.ts","./packages/extension/src/api/terminal.ts","./packages/extension/src/api/types.ts","./packages/extension/src/api/ws.ts","./packages/extension/src/worker/index.ts","./packages/extension/src/worker/setupfile.ts","./packages/shared/src/emitter.ts","./packages/shared/src/index.ts","./packages/shared/src/rpc.ts","./packages/shared/src/utils.ts","./packages/worker/src/coverage.ts","./packages/worker/src/index.ts","./packages/worker/src/reporter.ts","./packages/worker/src/runner.ts","./packages/worker/src/watcher.ts","./packages/worker/src/worker.ts","./packages/worker-legacy/src/collect.ts","./packages/worker-legacy/src/coverage.ts","./packages/worker-legacy/src/index.ts","./packages/worker-legacy/src/reporter.ts","./packages/worker-legacy/src/types.ts","./packages/worker-legacy/src/watcher.ts","./packages/worker-legacy/src/worker.ts"],"version":"5.8.3"}
1+
{"root":["./debug-shims.d.ts","./packages/extension/src/api.ts","./packages/extension/src/config.ts","./packages/extension/src/constants.ts","./packages/extension/src/coverage.ts","./packages/extension/src/debug.ts","./packages/extension/src/diagnostic.ts","./packages/extension/src/extension.ts","./packages/extension/src/inlineConsoleLog.ts","./packages/extension/src/log.ts","./packages/extension/src/polyfills.ts","./packages/extension/src/runner.ts","./packages/extension/src/tagsManager.ts","./packages/extension/src/testTree.ts","./packages/extension/src/testTreeData.ts","./packages/extension/src/utils.ts","./packages/extension/src/watcher.ts","./packages/extension/src/api/child_process.ts","./packages/extension/src/api/pkg.ts","./packages/extension/src/api/resolve.ts","./packages/extension/src/api/rpc.ts","./packages/extension/src/api/terminal.ts","./packages/extension/src/api/types.ts","./packages/extension/src/api/ws.ts","./packages/extension/src/worker/browserSetupFile.ts","./packages/extension/src/worker/index.ts","./packages/shared/src/emitter.ts","./packages/shared/src/index.ts","./packages/shared/src/rpc.ts","./packages/shared/src/utils.ts","./packages/worker/src/coverage.ts","./packages/worker/src/index.ts","./packages/worker/src/reporter.ts","./packages/worker/src/runner.ts","./packages/worker/src/watcher.ts","./packages/worker/src/worker.ts","./packages/worker-legacy/src/collect.ts","./packages/worker-legacy/src/coverage.ts","./packages/worker-legacy/src/index.ts","./packages/worker-legacy/src/reporter.ts","./packages/worker-legacy/src/setupFile.ts","./packages/worker-legacy/src/types.ts","./packages/worker-legacy/src/watcher.ts","./packages/worker-legacy/src/worker.ts"],"version":"5.8.3"}

0 commit comments

Comments
 (0)