Success on errors in deployment?

[sinnbeck]

I have noticed that if there are any errors in my deploy script it still succeeds. Am I doing something wrong or is it meant to be like that? I would expect it to send me a mail if anything goes wrong, so I can fix it right away. Otherwise I could have my site in a broken state. This also makes me fearful to enable modern deployments, if it will switch to a broken deployment.

Is there some setting I cannot find or do we need to do something in our deployment scripts manually?

I also use ploi, and there it stops the deployment on error if any of the steps fail.

Here is part of a deploy log that failed.

✗ Build failed in 3.58s

error during build:
[vite:load-fallback] Could not load /resources/js/actions/App/Http/Controllers/Auth/PasswordResetLinkController (imported by resources/js/pages/auth/forgot-password.tsx): ENOENT: no such file or directory, open '/resources/js/actions/App/Http/Controllers/Auth/PasswordResetLinkController'
    at async open (node:internal/fs/promises:641:25)
    at async Object.readFile (node:internal/fs/promises:1245:14)
    at async Object.handler (file:///home/vito/SITENAME/node_modules/vite/dist/node/chunks/dep-M_KD0XSK.js:33969:21)
    at async PluginDriver.hookFirstAndGetPlugin (file:///home/vito/SITENAME/node_modules/rollup/dist/es/shared/node-entry.js:22233:28)
    at async file:///home/vito/cSITENAME/node_modules/rollup/dist/es/shared/node-entry.js:21237:33
    at async Queue.work (file:///home/vito/SITENAME/node_modules/rollup/dist/es/shared/node-entry.js:22461:32)

🚀 Application deployed!

And the status is green with the text Finished

Edit: I found this article. https://betterdev.blog/minimal-safe-bash-script-template/#fail-fast
It seems it might be a good idea to always add set -Eeuo pipefail to the start of deploy scripts. I guess this is what ploi does automatically. Perhaps vito could do that too? If not, it might be a good idea to have it in the docs at least

[saeedvaziry]

Vito makes sure it runs the script for you like how the OS does.

The deployment script by default just runs the script, however it is also able to catch exceptions and fail the deployment if you configure your script in that way.

Any exit 1 will fail the deployment so a simple way of achieving it is to put set -e on top of your deployment script

[sinnbeck]

So you dont like the idea of having it as default ? Neither forge or ploi seems to require you to do so manually, so I bet they do it automatically :)
https://forge.laravel.com/docs/sites/deployments
https://ploi.io/documentation/deployment/how-do-i-deploy

My idea would be to add it after this line, as the bash script is already being altered here.
https://github.com/vitodeploy/vito/blob/3.x/app/SSH/OS/OS.php#L237

[saeedvaziry]

I like it but I don't want to introduce breaking changes. So maybe something for the next major release

[saeedvaziry]

feel free to open a PR to branch 4.x

[sinnbeck]

Ok I will look into that. On a similar note, it might be a good idea to add it to the update script as well. Currently if it fails, it will just keep on running until it says it was successful. So If you dont read all of the output, you might miss that your update of vito failed :)

[saeedvaziry]

Ok I will look into that. On a similar note, it might be a good idea to add it to the update script as well. Currently if it fails, it will just keep on running until it says it was successful. So If you dont read all of the output, you might miss that your update of vito failed :)

Valid idea