Merge pull request #145 from samtsai/add-schema-for-rule-options

fix: add missing schema so eslint would accept options

Author: vitonsky

src/rules/alias.test.ts

@@ -57,6 +57,13 @@ tester.run('paths-alias', rule, {
 			errors: ['Update import to @foo/x/y/z'],
 			output: `import z from '@foo/x/y/z';`,
 		},
+		{
+			name: 'relative named import from alias must be fixed',
+			filename: path.resolve('./src/nested/index.ts'),
+			code: `import { x } from '../qux/x/y/z';`,
+			errors: ['Update import to @qux/x/y/z'],
+			output: `import { x } from '@qux/x/y/z';`,
+		},
 		{
 			name: 'absolute import from alias must be fixed',
 			filename: path.resolve('./src/index.ts'),

src/rules/alias.ts

@@ -49,8 +49,7 @@ function findAlias(
 		// Remove basedir and slash in start
 		const slicedImportPath = importPath
 			.slice(baseDir.length + 1)
-			.slice(path.dirname(matchedPath).length + 1);
-
+			.slice(path.dirname(path.normalize(matchedPath)).length + 1);
 		// Remove asterisk from end of alias
 		const replacedPathSegments = path
 			.join(path.dirname(alias), slicedImportPath)
@@ -72,6 +71,21 @@ function findAlias(
 const rule: Rule.RuleModule = {
 	meta: {
 		fixable: 'code',
+		schema: {
+			type: 'array',
+			minItems: 0,
+			maxItems: 1,
+			items: [
+				{
+					type: 'object',
+					properties: {
+						configFilePath: { type: 'string' },
+						ignoredPaths: { type: 'array', items: { type: 'string' } },
+					},
+					additionalProperties: false,
+				},
+			],
+		},
 	},
 	create(context) {
 		const baseDir = findDirWithFile('package.json');

tsconfig.json

@@ -33,7 +33,8 @@
 		"baseUrl": ".",
 		"paths": {
 			"@foo/*": ["src/foo/*"],
-			"@bar/*": ["src/bar/*"]
+			"@bar/*": ["src/bar/*"],
+			"@qux/*": ["./src/qux/*"]
 		}
 	},
 	"include": ["src/*.ts", "src/*.tsx", "src/**/*.ts", "src/**/*.tsx"]