StorageManager::getDirectory should throw SecurityError for opaque origin

rdar://152269409
https://bugs.webkit.org/show_bug.cgi?id=293763

Reviewed by Per Arne Vollan.

To match the behavior in other browsers.

* LayoutTests/imported/w3c/web-platform-tests/file-system-access/opaque-origin.https.window-expected.txt:
* LayoutTests/imported/w3c/web-platform-tests/fs/opaque-origin.https.window-expected.txt:
* Source/WebCore/Modules/storage/StorageManager.cpp:
(WebCore::connectionInfo):
(WebCore::StorageManager::persisted):
(WebCore::StorageManager::persist):
(WebCore::StorageManager::estimate):
(WebCore::StorageManager::fileSystemAccessGetDirectory):

Canonical link: https://commits.webkit.org/295843@main

Author: szewai

LayoutTests/imported/w3c/web-platform-tests/file-system-access/opaque-origin.https.window-expected.txt

@@ -2,5 +2,5 @@
 PASS showDirectoryPicker() must be undefined for data URI iframes.
 PASS FileSystemDirectoryHandle must be undefined for data URI iframes.
 FAIL navigator.storage.getDirectory() and showDirectoryPicker() must reject in a sandboxed iframe. assert_equals: expected "showDirectoryPicker(): REJECTED: SecurityError" but got "showDirectoryPicker(): EXCEPTION: TypeError"
-FAIL navigator.storage.getDirectory() and showDirectoryPicker() must reject in a sandboxed opened window. assert_equals: expected "showDirectoryPicker(): REJECTED: SecurityError" but got "navigator.storage.getDirectory(): REJECTED: TypeError"
+FAIL navigator.storage.getDirectory() and showDirectoryPicker() must reject in a sandboxed opened window. assert_equals: expected "showDirectoryPicker(): REJECTED: SecurityError" but got "navigator.storage.getDirectory(): REJECTED: SecurityError"
 

LayoutTests/imported/w3c/web-platform-tests/fs/opaque-origin.https.window-expected.txt

@@ -1,5 +1,5 @@
 
 FAIL FileSystemDirectoryHandle must be defined for data URI iframes. assert_true: Data URI iframes must define 'FileSystemDirectoryHandle'. expected true got false
-FAIL navigator.storage.getDirectory() must reject in a sandboxed iframe. assert_equals: expected "navigator.storage.getDirectory(): REJECTED: SecurityError" but got "navigator.storage.getDirectory(): REJECTED: TypeError"
-FAIL navigator.storage.getDirectory() must reject in a sandboxed opened window. assert_equals: expected "navigator.storage.getDirectory(): REJECTED: SecurityError" but got "navigator.storage.getDirectory(): REJECTED: TypeError"
+PASS navigator.storage.getDirectory() must reject in a sandboxed iframe.
+PASS navigator.storage.getDirectory() must reject in a sandboxed opened window.
 

Source/WebCore/Modules/storage/StorageManager.cpp

@@ -62,7 +62,7 @@ struct ConnectionInfo {
     ClientOrigin origin;
 };
 
-static ExceptionOr<ConnectionInfo> connectionInfo(NavigatorBase* navigator)
+static ExceptionOr<ConnectionInfo> connectionInfo(NavigatorBase* navigator, ExceptionCode exceptionCodeForNoAccess)
 {
     if (!navigator)
         return Exception { ExceptionCode::InvalidStateError, "Navigator does not exist"_s };
@@ -72,7 +72,7 @@ static ExceptionOr<ConnectionInfo> connectionInfo(NavigatorBase* navigator)
         return Exception { ExceptionCode::InvalidStateError, "Context is invalid"_s };
 
     if (context->canAccessResource(ScriptExecutionContext::ResourceType::StorageManager) == ScriptExecutionContext::HasResourceAccess::No)
-        return Exception { ExceptionCode::TypeError, "Context not access storage"_s };
+        return Exception { exceptionCodeForNoAccess, "Context not access storage"_s };
 
     RefPtr origin = context->securityOrigin();
     ASSERT(origin);
@@ -92,7 +92,7 @@ static ExceptionOr<ConnectionInfo> connectionInfo(NavigatorBase* navigator)
 
 void StorageManager::persisted(DOMPromiseDeferred<IDLBoolean>&& promise)
 {
-    auto connectionInfoOrException = connectionInfo(m_navigator.get());
+    auto connectionInfoOrException = connectionInfo(m_navigator.get(), ExceptionCode::TypeError);
     if (connectionInfoOrException.hasException())
         return promise.reject(connectionInfoOrException.releaseException());
 
@@ -104,7 +104,7 @@ void StorageManager::persisted(DOMPromiseDeferred<IDLBoolean>&& promise)
 
 void StorageManager::persist(DOMPromiseDeferred<IDLBoolean>&& promise)
 {
-    auto connectionInfoOrException = connectionInfo(m_navigator.get());
+    auto connectionInfoOrException = connectionInfo(m_navigator.get(), ExceptionCode::TypeError);
     if (connectionInfoOrException.hasException())
         return promise.reject(connectionInfoOrException.releaseException());
 
@@ -116,7 +116,7 @@ void StorageManager::persist(DOMPromiseDeferred<IDLBoolean>&& promise)
 
 void StorageManager::estimate(DOMPromiseDeferred<IDLDictionary<StorageEstimate>>&& promise)
 {
-    auto connectionInfoOrException = connectionInfo(m_navigator.get());
+    auto connectionInfoOrException = connectionInfo(m_navigator.get(), ExceptionCode::TypeError);
     if (connectionInfoOrException.hasException())
         return promise.reject(connectionInfoOrException.releaseException());
 
@@ -128,7 +128,7 @@ void StorageManager::estimate(DOMPromiseDeferred<IDLDictionary<StorageEstimate>>
 
 void StorageManager::fileSystemAccessGetDirectory(DOMPromiseDeferred<IDLInterface<FileSystemDirectoryHandle>>&& promise)
 {
-    auto connectionInfoOrException = connectionInfo(m_navigator.get());
+    auto connectionInfoOrException = connectionInfo(m_navigator.get(), ExceptionCode::SecurityError);
     if (connectionInfoOrException.hasException())
         return promise.reject(connectionInfoOrException.releaseException());