forked from DeepSourceCorp/globstar
-
Notifications
You must be signed in to change notification settings - Fork 0
Expand file tree
/
Copy pathavoid-unsanitized-sql.test.py
More file actions
44 lines (33 loc) · 1.12 KB
/
avoid-unsanitized-sql.test.py
File metadata and controls
44 lines (33 loc) · 1.12 KB
1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
import sqlite3
from fastapi import FastAPI, Query
import sqlite3
app = FastAPI()
def execute_unsafe_query(query: str):
conn = sqlite3.connect("test.db")
cursor = conn.cursor()
#<expect-error>
cursor.execute(query) #unsafe with user input
result = cursor.fetchall()
conn.commit()
conn.close()
return result
def better_query(query: str, params):
conn = sqlite3.connect("test.db")
cursor = conn.cursor()
cursor.execute(query, params) #safe to execute with user input
result = cursor.fetchall()
conn.commit()
conn.close()
return result
@app.get("/unsafe_query/")
def unsafe_query(user_input: str):
#f-string case
query = f"SELECT * FROM users WHERE name = {user_input}"
#binary operator case
query2= "SELECT * FROM users WHERE name ="+ user_input
#should not identify this as an error
query3= "SELECT * FROM user WHERE name= ?"
result = execute_unsafe_query(query)
result2= execute_unsafe_query(query=query2)
result3= better_query(query=query3, params=(user_input,))
return {"result": result, "result2": result2, "result3": result3}