feat: dropUnknownIndexes #12
Conversation
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Summary of Changes
Hello @RahulLanjewar93, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!
This pull request introduces a new configuration option, "dropUnknownIndexes", to enhance control over database index management during schema migrations. This feature allows administrators to prevent the automatic deletion of indexes that are not explicitly defined within the Parse Server schema, which is particularly useful for environments where indexes are managed externally or manually. The changes ensure that the schema migration process respects this new setting, providing greater flexibility and preventing unintended data structure modifications.
Highlights
- New Configuration Option: Introduced "dropUnknownIndexes" in schema options, allowing users to control whether indexes not explicitly defined in the schema are automatically dropped from the database.
- Enhanced Index Management: This new option, defaulting to "true", provides flexibility for environments where indexes might be managed manually or by other tools, preventing unintended index deletions during schema migrations.
- Schema Migration Logic Update: The schema migration process has been updated to respect the "dropUnknownIndexes" setting, ensuring that only unwanted indexes are removed when the option is enabled.
- Improved Test Coverage: A new test case was added to "DefinedSchemas.spec.js" to verify the behavior of "dropUnknownIndexes" when set to "false", ensuring that indexes are not deleted as expected.
Using Gemini Code Assist
The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.
Invoking Gemini
You can request assistance from Gemini at any point in your pull request via creating an issue comment (i.e. comment on the pull request page) using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands.
| Feature | Command | Description |
|---|---|---|
| Code Review | /gemini review |
Performs a code review for the current pull request in its current state. |
| Pull Request Summary | /gemini summary |
Provides a summary of the current pull request in its current state. |
| Comment | @gemini-code-assist | Responds in comments when explicitly tagged, both in issue comments and review comments. |
| Help | /gemini help |
Displays a list of available commands. |
Customization
To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.
Limitations & Feedback
Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.
You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.
Footnotes
-
Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩
There was a problem hiding this comment.
Code Review
This pull request introduces a new dropUnknownIndexes option to control whether database indexes not defined in the schema are dropped during migration. The implementation looks good, but there are a few issues. The logic for checking the new option is inconsistent with how other options are handled, which could lead to incorrect behavior. Additionally, the new tests have misleading descriptions that are inverted with respect to the logic they are testing. I've provided suggestions to fix these issues.
|
lets wait for parse-community#9857. If that is merged i will cherry pick it and update this pr @hariprasadiit |
Pull Request
Issue
Closes: FILL_THIS_OUT
Approach
Tasks