🐛 Fix error path cleanup consistency and add field selection warning

Address PR review feedback:

- Add output.cleanup() to all error paths before process.exit()
- Add debug-level warning when field selection doesn't find requested fields
- Ensures spinners and other terminal state are properly cleaned up on errors

Files fixed:
- api.js, review.js (approve/reject/comment), builds.js, comparisons.js
- config-cmd.js, orgs.js, projects.js, baselines.js

Author: Robdel12

src/commands/api.js

@@ -176,6 +176,7 @@ export async function apiCommand(
     }
 
     output.error('API request failed', error);
+    output.cleanup();
     exit(1);
   }
 }

src/commands/baselines.js

@@ -127,6 +127,7 @@ export async function baselinesCommand(
           return;
         }
         output.error(`Baseline "${options.info}" not found`);
+        output.cleanup();
         exit(1);
         return;
       }
@@ -287,6 +288,7 @@ export async function baselinesCommand(
     output.cleanup();
   } catch (error) {
     output.error('Failed to read baselines', error);
+    output.cleanup();
     exit(1);
   }
 }

src/commands/builds.js

@@ -161,6 +161,7 @@ export async function buildsCommand(
   } catch (error) {
     output.stopSpinner();
     output.error('Failed to fetch builds', error);
+    output.cleanup();
     exit(1);
   }
 }

src/commands/comparisons.js

@@ -178,6 +178,7 @@ export async function comparisonsCommand(
   } catch (error) {
     output.stopSpinner();
     output.error('Failed to fetch comparisons', error);
+    output.cleanup();
     exit(1);
   }
 }

src/commands/config-cmd.js

@@ -146,6 +146,7 @@ export async function configCommand(
     output.cleanup();
   } catch (error) {
     output.error('Failed to load configuration', error);
+    output.cleanup();
     exit(1);
   }
 }

src/commands/orgs.js

@@ -26,6 +26,7 @@ export async function orgsCommand(_options = {}, globalOptions = {}) {
       output.error(
         'API token required. Use --token, set VIZZLY_TOKEN, or run "vizzly login"'
       );
+      output.cleanup();
       process.exit(1);
     }
 
@@ -81,6 +82,7 @@ export async function orgsCommand(_options = {}, globalOptions = {}) {
   } catch (error) {
     output.stopSpinner();
     output.error('Failed to fetch organizations', error);
+    output.cleanup();
     process.exit(1);
   }
 }

src/commands/projects.js

@@ -26,6 +26,7 @@ export async function projectsCommand(options = {}, globalOptions = {}) {
       output.error(
         'API token required. Use --token, set VIZZLY_TOKEN, or run "vizzly login"'
       );
+      output.cleanup();
       process.exit(1);
     }
 
@@ -103,6 +104,7 @@ export async function projectsCommand(options = {}, globalOptions = {}) {
   } catch (error) {
     output.stopSpinner();
     output.error('Failed to fetch projects', error);
+    output.cleanup();
     process.exit(1);
   }
 }

src/commands/review.js

@@ -101,6 +101,7 @@ export async function approveCommand(
     }
 
     output.error('Failed to approve comparison', error);
+    output.cleanup();
     exit(1);
   }
 }
@@ -198,6 +199,7 @@ export async function rejectCommand(
     }
 
     output.error('Failed to reject comparison', error);
+    output.cleanup();
     exit(1);
   }
 }
@@ -298,6 +300,7 @@ export async function commentCommand(
     }
 
     output.error('Failed to add comment', error);
+    output.cleanup();
     exit(1);
   }
 }

src/utils/output.js

@@ -129,6 +129,7 @@ function setNestedValue(obj, path, value) {
 /**
  * Select specific fields from an object
  * Supports dot notation for nested fields (e.g., "comparisons.total")
+ * Warns in debug mode when requested fields aren't found
  * @param {Object|Array} obj - Source object or array
  * @param {string[]} fields - Fields to select
  * @returns {Object|Array} Object with only selected fields
@@ -143,12 +144,26 @@ function selectFields(obj, fields) {
   }
 
   let result = {};
+  let missingFields = [];
+
   for (let field of fields) {
     let value = getNestedValue(obj, field);
     if (value !== undefined) {
       setNestedValue(result, field, value);
+    } else {
+      missingFields.push(field);
     }
   }
+
+  // Warn about missing fields in verbose mode
+  if (missingFields.length > 0 && shouldLog('debug')) {
+    console.error(
+      colors.dim(
+        `Note: Requested field(s) not found: ${missingFields.join(', ')}`
+      )
+    );
+  }
+
   return result;
 }