🧪 Add tests for #158 and #160 fixes, remove unnecessary bind

- Add tests for _upsertComparison() method verifying deduplication
- Add test for daemon mode stale result prevention
- Add test verifying minClusterSize is passed from config to runOptions
- Remove unnecessary this._upsertComparison.bind() call

Author: Robdel12

src/tdd/tdd-service.js

@@ -259,9 +259,6 @@ export class TddService {
     // Track whether results have been printed (to avoid duplicate output)
     this._resultsPrinted = false;
 
-    // Bind the helper method
-    this._upsertComparison = this._upsertComparison.bind(this);
-
     if (this.setBaseline) {
       output.info(
         '[vizzly] Baseline update mode - will overwrite existing baselines with new ones'

tests/commands/run.test.js

@@ -435,6 +435,49 @@ describe('commands/run', () => {
       assert.strictEqual(exitCode, 1);
     });
 
+    it('passes minClusterSize from config to runOptions', async () => {
+      // This test verifies the fix for issue #160
+      let output = createMockOutput();
+      let capturedRunOptions = null;
+
+      await runCommand(
+        'npm test',
+        {},
+        {},
+        {
+          loadConfig: async () =>
+            createMockConfig({
+              comparison: { threshold: 2.0, minClusterSize: 5 },
+            }),
+          createServerManager: () => ({
+            start: async () => {},
+            stop: async () => {},
+          }),
+          createUploader: () => ({}),
+          runTests: async ({ runOptions }) => {
+            capturedRunOptions = runOptions;
+            return { buildId: null, screenshotsCaptured: 0 };
+          },
+          detectBranch: async () => 'main',
+          detectCommit: async () => 'abc123',
+          detectCommitMessage: async () => 'test',
+          detectPullRequestNumber: () => null,
+          generateBuildNameWithGit: async () => 'test-build',
+          output,
+          exit: () => {},
+          processOn: () => {},
+          processRemoveListener: () => {},
+        }
+      );
+
+      assert.strictEqual(
+        capturedRunOptions.minClusterSize,
+        5,
+        'minClusterSize should be passed from config to runOptions'
+      );
+      assert.strictEqual(capturedRunOptions.threshold, 2.0);
+    });
+
     it('uses provided git metadata options', async () => {
       let output = createMockOutput();
       let capturedRunOptions = null;

tests/tdd/tdd-service.test.js

@@ -346,6 +346,93 @@ describe('tdd/tdd-service', () => {
     });
   });
 
+  describe('_upsertComparison', () => {
+    it('replaces existing comparison when ID matches', () => {
+      let mockDeps = createMockDeps();
+      let service = new TddService({}, '/test', false, null, mockDeps);
+
+      // Add initial comparison
+      service.comparisons = [
+        { id: 'comp-1', name: 'homepage', status: 'failed', diffPercentage: 5.0 },
+        { id: 'comp-2', name: 'button', status: 'passed' },
+      ];
+
+      // Upsert with same ID but different status
+      service._upsertComparison({
+        id: 'comp-1',
+        name: 'homepage',
+        status: 'passed',
+        diffPercentage: 0,
+      });
+
+      assert.strictEqual(service.comparisons.length, 2);
+      assert.strictEqual(service.comparisons[0].status, 'passed');
+      assert.strictEqual(service.comparisons[0].diffPercentage, 0);
+    });
+
+    it('appends new comparison when ID does not exist', () => {
+      let mockDeps = createMockDeps();
+      let service = new TddService({}, '/test', false, null, mockDeps);
+
+      service.comparisons = [
+        { id: 'comp-1', name: 'homepage', status: 'passed' },
+      ];
+
+      service._upsertComparison({
+        id: 'comp-2',
+        name: 'button',
+        status: 'new',
+      });
+
+      assert.strictEqual(service.comparisons.length, 2);
+      assert.strictEqual(service.comparisons[1].id, 'comp-2');
+    });
+
+    it('prevents stale results from accumulating in daemon mode', async () => {
+      // This test verifies the fix for issue #158
+      // In daemon mode, re-running tests should replace old results, not accumulate them
+      let mockDeps = createMockDeps({
+        baseline: { baselineExists: () => true },
+        comparison: {
+          compareImages: async () => ({
+            isDifferent: true,
+            diffPercentage: 5.5,
+            diffPixels: 1000,
+            diffClusters: [],
+          }),
+          buildFailedComparison: params => ({
+            id: params.signature ? `comp-${params.signature}` : 'test-id',
+            status: 'failed',
+            ...params,
+          }),
+        },
+        signature: {
+          generateScreenshotSignature: () => 'homepage|1920|chrome',
+          generateBaselineFilename: () => 'homepage_hash.png',
+          generateComparisonId: sig => `comp-${sig}`,
+          sanitizeScreenshotName: name => name,
+          validateScreenshotProperties: props => props,
+          safePath: (...parts) => parts.join('/'),
+        },
+      });
+      let service = new TddService({}, '/test', false, null, mockDeps);
+
+      // First run - screenshot fails
+      await service.compareScreenshot('homepage', Buffer.from('test1'), {});
+      assert.strictEqual(service.comparisons.length, 1);
+      assert.strictEqual(service.comparisons[0].status, 'failed');
+
+      // Second run - same screenshot, still fails (simulating daemon mode re-run)
+      // Without the fix, this would add a second comparison
+      await service.compareScreenshot('homepage', Buffer.from('test2'), {});
+      assert.strictEqual(
+        service.comparisons.length,
+        1,
+        'Should still have only 1 comparison, not 2'
+      );
+    });
+  });
+
   describe('compareScreenshot', () => {
     it('creates new baseline when none exists', async () => {
       let savedBaseline = null;