Fix clang-tidy

Author: schaumb

src/chart/options/config.cpp

@@ -211,12 +211,12 @@ void Config::setChannelParam(const std::string &path,
 		if (parts.size() == 3 && value == "null")
 			channel.reset();
 		else {
-			if (auto command = parts.size() == 4
-			                     ? "name"
-			                     : std::string_view{parts.at(4)};
+			if (const std::string_view command =
+			        parts.size() == 4 ? std::string_view{"name"}
+			                          : parts.at(4);
 			    command == "name") {
 				if (std::stoi(parts.at(3)) == 0) channel.reset();
-				if (value == "") { channel.measureId.emplace(); }
+				if (value.empty()) { channel.measureId.emplace(); }
 				else
 					channel.addSeries({value, table});
 			}

src/dataframe/impl/data_source.h

@@ -29,6 +29,12 @@ enum class error_type {
 	internal_error
 };
 
+struct series_meta_t
+{
+	std::string_view name;
+	series_type type;
+};
+
 [[maybe_unused]] [[noreturn]] void error(error_type err,
     std::string_view arg = {});
 

src/dataframe/impl/dataframe.cpp

@@ -722,8 +722,7 @@ std::string dataframe::get_record_id_by_dims(std::size_t my_record,
 	return get_data_source().get_id(my_record, dimensions);
 }
 
-dataframe::series_meta_t dataframe::get_series_meta(
-    const std::string &id) const
+series_meta_t dataframe::get_series_meta(const std::string &id) const
 {
 	switch (auto &&ser = get_data_source().get_series(id)) {
 		using enum series_type;

src/dataframe/impl/dataframe.h

@@ -117,12 +117,6 @@ class dataframe
 	[[nodiscard]] std::span<const std::string> get_categories(
 	    const std::string_view &dimension) const &;
 
-	struct series_meta_t
-	{
-		std::string_view name;
-		series_type type;
-	};
-
 	[[nodiscard]] series_meta_t get_series_meta(
 	    const std::string &id) const;
 

src/dataframe/old/datatable.cpp

@@ -8,6 +8,7 @@
 #include "base/text/funcstring.h"
 #include "chart/options/options.h"
 #include "dataframe/impl/aggregators.h"
+#include "dataframe/impl/data_source.h"
 #include "dataframe/interface.h"
 
 namespace Vizzu::Data
@@ -53,15 +54,18 @@ const MultiIndex &DataCube::iterator_t::operator*() const
 	return index;
 }
 
-SeriesIndex::SeriesIndex(std::string const &str,
-    const DataTable &table)
+SeriesIndex::SeriesIndex(dataframe::series_meta_t const &meta) :
+    name{meta.name}
 {
-	auto &&[s, type] = table.getDf().get_series_meta(str);
-	name = s;
-	if (type == DataTable::Type::measure)
-		aggregator = dataframe::aggregator_type::sum;
+	if (meta.type == dataframe::series_type::measure)
+		aggregator.emplace(dataframe::aggregator_type::sum);
 }
 
+SeriesIndex::SeriesIndex(std::string const &str,
+    const DataTable &table) :
+    SeriesIndex(table.getDf().get_series_meta(str))
+{}
+
 void SeriesIndex::setAggr(const std::string &aggr)
 {
 	aggregator = Refl::get_enum<dataframe::aggregator_type>(aggr);

src/dataframe/old/types.h

@@ -7,6 +7,11 @@
 
 #include "../interface.h"
 
+namespace Vizzu::dataframe
+{
+struct series_meta_t;
+}
+
 namespace Vizzu::Data
 {
 
@@ -30,6 +35,8 @@ class SeriesIndex
 	std::string_view name{};
 	std::optional<dataframe::aggregator_type> aggregator;
 
+	explicit SeriesIndex(dataframe::series_meta_t const &meta);
+
 public:
 	SeriesIndex() : aggregator(dataframe::aggregator_type::count) {}
 	SeriesIndex(std::string const &str, const DataTable &table);