Fix unique testcase

Author: schaumb

CHANGELOG.md

@@ -2,6 +2,15 @@
 
 ## [Unreleased]
 
+### Fixed
+
+- From now vertical line connections are curved lines.
+- Remove duplicated circles on line-circle transition.
+- Fix area-circle polar connection transition.
+- Fix line-rectangle polar connection linearity.
+- Fix all polar connection interpolation (except fading).
+- Remove unwanted line connections from line-circle + orientation changed anim.
+
 ## [0.13.0] - 2024-09-13
 
 ### Fixed

src/chart/rendering/markers/connectingmarker.cpp

@@ -47,12 +47,19 @@ ConnectingMarker::ConnectingMarker(const DrawingContext &ctx,
 	    ctx.getOptions().orientation.factor<Math::FuzzyBool>(
 	        Gen::Orientation::horizontal);
 
-	linear = !polar || horizontal;
-
 	auto &&isHorizontal =
 	    ctx.getOptions().orientation.get_or_first(lineIndex).value
 	    == Gen::Orientation::horizontal;
 
+	linear = !polar || horizontal
+	      || Math::FuzzyBool::And(
+	          !isHorizontal
+	              && ctx.plot->axises.at(Gen::Channel::Type::x)
+	                     .dimension.enabled,
+	          ctx.plot->axises.at(Gen::Channel::Type::x)
+	              .measure.enabled.factor(false),
+	          !horizontal);
+
 	lineWidth[0] = lineWidth[1] = 0;
 
 	const auto *prev =

src/chart/rendering/painter/drawline.cpp

@@ -54,7 +54,7 @@ DrawLine::DrawLine(const Geom::Line &line,
 			                options.coordSys.getOriginal(p1),
 			                options.coordSys.getOriginal(p2),
 			                options.coordSys.getOriginal(p3)},
-			    {static_cast<PathSampler::Options>(options),
+			    {static_cast<const PathSampler::Options &>(options),
 			        {.toCircleFactor = 0,
 			            .straightFactor = options.straightFactor}},
 			    canvas,

test/e2e/test_cases/test_cases.json

@@ -185,13 +185,13 @@
 			"refs": ["dae308e"]
 		},
 		"data_fault_and_formats/column_rectangle_less_disc": {
-			"refs": ["f2cce92"]
+			"refs": ["e84920a"]
 		},
 		"data_fault_and_formats/column_rectangle_more_conti": {
 			"refs": ["7ebabe4"]
 		},
 		"data_fault_and_formats/column_rectangle_more_disc": {
-			"refs": ["87e3a08"]
+			"refs": ["2c2e36e"]
 		},
 		"data_fault_and_formats/rectangle_data_cube": {
 			"refs": ["e504add"]
@@ -1151,28 +1151,28 @@
 			"refs": ["df5e0ee"]
 		},
 		"ww_animTiming/descartes-polar_orient/09_d-p_o_r-a-r": {
-			"refs": ["915f0e7"]
+			"refs": ["4f241d6"]
 		},
 		"ww_animTiming/descartes-polar_orient/10_d-p_o_c-a-c": {
 			"refs": ["a2a9605"]
 		},
 		"ww_animTiming/descartes-polar_orient/11_d-p_o_a-a-a": {
-			"refs": ["ae824e3"]
+			"refs": ["bf6abe1"]
 		},
 		"ww_animTiming/descartes-polar_orient/12_d-p_o_l-a-l": {
-			"refs": ["a2ac0fe"]
+			"refs": ["fb238ec"]
 		},
 		"ww_animTiming/descartes-polar_orient/13_d-p_o_r-l-r": {
-			"refs": ["d4f67e3"]
+			"refs": ["6a458bb"]
 		},
 		"ww_animTiming/descartes-polar_orient/14_d-p_o_c-l-c": {
-			"refs": ["a0d648f"]
+			"refs": ["47b646a"]
 		},
 		"ww_animTiming/descartes-polar_orient/15_d-p_o_a-l-a": {
-			"refs": ["bc84b66"]
+			"refs": ["2b08ef5"]
 		},
 		"ww_animTiming/descartes-polar_orient/16_d-p_o_l-l-l": {
-			"refs": ["e148dab"]
+			"refs": ["1061105"]
 		},
 		"ww_animTiming/descartes/02_d-d_c-r-c": {
 			"refs": ["3faedf5"]
@@ -1292,28 +1292,28 @@
 			"refs": ["e137c9a"]
 		},
 		"ww_animTiming/polar_orientation/09_p-p_o_r-a-r": {
-			"refs": ["e9c6c6c"]
+			"refs": ["7356a12"]
 		},
 		"ww_animTiming/polar_orientation/10_p-p_o_c-a-c": {
-			"refs": ["3112502"]
+			"refs": ["b770021"]
 		},
 		"ww_animTiming/polar_orientation/11_p-p_o_a-a-a": {
-			"refs": ["79d5d9c"]
+			"refs": ["3432c12"]
 		},
 		"ww_animTiming/polar_orientation/12_p-p_o_l-a-l": {
 			"refs": ["75ba273"]
 		},
 		"ww_animTiming/polar_orientation/13_p-p_o_r-l-r": {
-			"refs": ["a7e0ab4"]
+			"refs": ["6a73484"]
 		},
 		"ww_animTiming/polar_orientation/14_p-p_o_c-l-c": {
-			"refs": ["123e4e2"]
+			"refs": ["eec715a"]
 		},
 		"ww_animTiming/polar_orientation/15_p-p_o_a-l-a": {
-			"refs": ["deba322"]
+			"refs": ["064b0b7"]
 		},
 		"ww_animTiming/polar_orientation/16_p-p_o_l-l-l": {
-			"refs": ["328ca4c"]
+			"refs": ["798b994"]
 		},
 		"ww_animTiming/without-descartes/01_w-d_r-r-r": {
 			"refs": ["b70c147"]
@@ -1484,7 +1484,7 @@
 			"refs": ["d1af57c"]
 		},
 		"ww_animTiming_TESTS/descartes-polar_orient/09_d-p_o_r-a-r": {
-			"refs": ["8d5c8f9"]
+			"refs": ["ed4d5c6"]
 		},
 		"ww_animTiming_TESTS/descartes-polar_orient/10_d-p_o_c-a-c": {
 			"refs": ["6c32188"]
@@ -1496,7 +1496,7 @@
 			"refs": ["3431b25"]
 		},
 		"ww_animTiming_TESTS/descartes-polar_orient/13_d-p_o_r-l-r": {
-			"refs": ["745bcc1"]
+			"refs": ["13ba67a"]
 		},
 		"ww_animTiming_TESTS/descartes-polar_orient/14_d-p_o_c-l-c": {
 			"refs": ["3e965dc"]
@@ -1625,10 +1625,10 @@
 			"refs": ["597a4a4"]
 		},
 		"ww_animTiming_TESTS/polar_orientation/09_p-p_o_r-a-r": {
-			"refs": ["2d97baa"]
+			"refs": ["0584e64"]
 		},
 		"ww_animTiming_TESTS/polar_orientation/10_p-p_o_c-a-c": {
-			"refs": ["238fd07"]
+			"refs": ["d1f70e0"]
 		},
 		"ww_animTiming_TESTS/polar_orientation/11_p-p_o_a-a-a": {
 			"refs": ["403eab0"]
@@ -1637,10 +1637,10 @@
 			"refs": ["5f58693"]
 		},
 		"ww_animTiming_TESTS/polar_orientation/13_p-p_o_r-l-r": {
-			"refs": ["741f884"]
+			"refs": ["9ec60a5"]
 		},
 		"ww_animTiming_TESTS/polar_orientation/14_p-p_o_c-l-c": {
-			"refs": ["cec95dc"]
+			"refs": ["4a68bd6"]
 		},
 		"ww_animTiming_TESTS/polar_orientation/15_p-p_o_a-l-a": {
 			"refs": ["69225cb"]

test/e2e/tests/fixes.json

@@ -20,7 +20,7 @@
 			"refs": ["e4b8a2f"]
 		},
 		"327": {
-			"refs": ["6b87c18"]
+			"refs": ["8eb7c5d"]
 		},
 		"333": {
 			"refs": ["6a5536c"]
@@ -50,7 +50,7 @@
 			"refs": ["034ee91"]
 		},
 		"47977099": {
-			"refs": ["2845349"]
+			"refs": ["1310b69"]
 		},
 		"53913538": {
 			"refs": ["90f6d38"]