Review + clang-tidy

Author: schaumb

src/base/type/booliter.h

@@ -19,6 +19,9 @@ struct Bools
 		return boolArr.data() + 1 + static_cast<bool>(max);
 	}
 };
+
+template <class T> Bools(T) -> Bools<T>;
+
 }
 
 #endif

src/chart/options/options.cpp

@@ -222,7 +222,7 @@ std::optional<Options::MarkerInfoId> Options::getMarkerInfoId(
 Options::MarkerInfoId Options::generateMarkerInfoId()
 {
 	static std::atomic<MarkerInfoId> nextMarkerInfoId{1};
-	return nextMarkerInfoId.fetch_add(1, std::memory_order_relaxed);
+	return nextMarkerInfoId.fetch_add(1, std::memory_order_acq_rel);
 }
 
 void Options::setAutoParameters()

src/chart/rendering/drawaxes.cpp

@@ -195,7 +195,8 @@ void DrawAxes::drawTitle(Gen::ChannelId axisIndex) const
 
 		Geom::AffineTransform transform(posDir.begin, 1.0, -posAngle);
 
-		auto calcOrientation = [&size](const auto &orientation)
+		auto calcOrientation =
+		    [&size](const Styles::AxisTitle::Orientation &orientation)
 		{
 			return Geom::Size{
 			    orientation

src/chart/speclayout/bubblechart.cpp

@@ -6,13 +6,14 @@
 namespace Vizzu::Charts
 {
 
-BubbleChart::BubbleChart(const std::vector<double> &sizes,
+BubbleChart::BubbleChart(const std::vector<double> &circleAreas,
     const Geom::Rect &rect)
 {
-	markers.reserve(sizes.size());
+	markers.reserve(circleAreas.size());
 
-	for (auto j = 0U; j < sizes.size(); ++j)
-		markers.emplace_back(j, std::sqrt(std::max(0.0, sizes[j])));
+	for (auto j = 0U; j < circleAreas.size(); ++j)
+		markers.emplace_back(j,
+		    std::sqrt(std::max(0.0, circleAreas[j])));
 
 	std::sort(markers.begin(), markers.end(), SpecMarker::sizeOrder);
 

src/chart/speclayout/bubblechart.h

@@ -18,7 +18,7 @@ class BubbleChart
 
 	Markers markers;
 
-	explicit BubbleChart(const std::vector<double> &sizes,
+	explicit BubbleChart(const std::vector<double> &circleAreas,
 	    const Geom::Rect &rect = Geom::Rect(Geom::Point{0, 0},
 	        Geom::Size{1, 1}));
 

src/chart/speclayout/specmarker.h

@@ -16,7 +16,9 @@ struct SpecMarker
 	double size;
 	std::variant<Geom::Rect, Geom::Circle> shape;
 
-	SpecMarker(size_t index, double size) : index(index), size(size)
+	SpecMarker(size_t index, double radiusOrAreaFactor) :
+	    index(index),
+	    size(radiusOrAreaFactor)
 	{}
 
 	template <typename... T> void emplaceCircle(T &&...params)