Merge pull request #582 from vizzuhq/Fix-channel-step

Fix channel step

Author: schaumb

CHANGELOG.md

@@ -4,6 +4,7 @@
 
 ### Fixed 
 
+- Fix again measure axis labels when the axis range and step set too.
 - Fix drilldown regroup strategy on fake-split charts.
 
 ## [0.13.0] - 2024-09-13

src/chart/rendering/drawinterlacing.cpp

@@ -146,7 +146,8 @@ void DrawInterlacing::draw(
 		auto iMin =
 		    axisBottom > 0
 		        ? std::floor(-axis.origo() / (2 * stripWidth)) * 2
-		        : std::round(axis.range.getMin() - stepSize);
+		        : std::round(
+		            (axis.range.getMin() - stepSize) / stepSize);
 
 		auto interlaceCount = 0U;
 		const auto maxInterlaceCount = 1000U;

test/e2e/tests/fixes.json

@@ -19,6 +19,9 @@
 		"163": {
 			"refs": ["a82431f"]
 		},
+		"252": {
+			"refs": ["00f01d9"]
+		},
 		"320": {
 			"refs": ["e4b8a2f"]
 		},

test/e2e/tests/fixes/252.mjs

@@ -0,0 +1,102 @@
+function time(y, m, d) {
+	return y + (m - 1) / 12 + (d - 1) / 31 / 12
+}
+
+const testSteps = [
+	(chart) =>
+		chart.animate({
+			data: {
+				series: [
+					{
+						name: 'Name',
+						type: 'dimension',
+						values: [
+							'Apple Pie',
+							'Banana Bread',
+							'Cupcake',
+							'Donut',
+							'Eclair',
+							'Froyo',
+							'Gingerbread',
+							'Honeycomb',
+							'Ice Cream Sandwich',
+							'Jelly Bean',
+							'KitKat',
+							'Lollipop',
+							'Marshmallow',
+							'Nougat',
+							'Orea'
+						]
+					},
+					{
+						name: 'Time',
+						type: 'measure',
+						values: [
+							time(2008, 9, 23),
+							time(2009, 4, 9),
+							time(2009, 4, 27),
+							time(2009, 9, 15),
+							time(2009, 10, 26),
+							time(2010, 4, 29),
+							time(2010, 12, 6),
+							time(2011, 2, 22),
+							time(2011, 10, 12),
+							time(2012, 4, 12),
+							time(2013, 10, 31),
+							time(2014, 11, 3),
+							time(2015, 10, 5),
+							time(2016, 8, 22),
+							time(2017, 8, 21)
+						]
+					},
+					{
+						name: 'Placement',
+						type: 'measure',
+						values: [1, -1, 1.5, -1.5, 1, -2, 1.5, -1.5, 1, -1, 1, -1, 1, -1, 1]
+					}
+				]
+			}
+		}),
+	(chart) =>
+		chart.animate({
+			config: {
+				x: {
+					set: 'Time',
+					range: { min: 2008.5, max: 2018.1 },
+					step: 1,
+					ticks: true,
+					title: null
+				},
+				y: {
+					set: 'Placement',
+					interlacing: false,
+					labels: false,
+					markerGuides: false,
+					title: null
+				},
+				label: 'Name',
+				geometry: 'circle'
+			},
+			style: {
+				plot: {
+					xAxis: {
+						label: {
+							numberFormat: 'none',
+							position: 'axis'
+						}
+					},
+					marker: {
+						guides: {
+							color: '#666666'
+						}
+					}
+				}
+			}
+		}),
+	(chart) =>
+		chart.animate({
+			x: { step: 2 }
+		})
+]
+
+export default testSteps