Skip to content
This repository was archived by the owner on Jun 22, 2024. It is now read-only.

Commit fc28a1d

Browse files
committed
Vulnerable configs can only be set in user or remote
1 parent b82347f commit fc28a1d

File tree

2 files changed

+19
-7
lines changed

2 files changed

+19
-7
lines changed

CHANGELOG.md

Lines changed: 6 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -4,6 +4,12 @@
44

55
-
66

7+
## 2.12.1
8+
9+
Fixes vulnerability which allowed malicous workspaces to execute code when opened by providing. Now the vulnerable configs cannot be overrided in workspaces anymore:
10+
`sourcekit-lsp.serverPath`, `swift.languageServerPath`, `swift.path.sourcekite`, `swift.path.sourcekiteDockerMode`, `swift.path.swift_driver_bin`, `swift.path.shell`.
11+
12+
713
## 2.12.0
814

915
- Better and more helpful error messages on first start

package.json

Lines changed: 13 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -8,7 +8,7 @@
88
"url": "https://github.com/vknabel"
99
},
1010
"license": "Apache-2.0",
11-
"version": "2.12.0",
11+
"version": "2.12.1",
1212
"publisher": "vknabel",
1313
"icon": "icons/icon.png",
1414
"galleryBanner": {
@@ -108,7 +108,8 @@
108108
"properties": {
109109
"sourcekit-lsp.serverPath": {
110110
"type": "string",
111-
"description": "The path of the sourcekit-lsp executable\nIn SDE: defaults to the toolchain's sourcekit-lsp."
111+
"description": "The path of the sourcekit-lsp executable\nIn SDE: defaults to the toolchain's sourcekit-lsp. Only available in global config for security reasons.",
112+
"scope": "machine"
112113
},
113114
"sourcekit-lsp.toolchainPath": {
114115
"type": "string",
@@ -117,26 +118,31 @@
117118
"swift.languageServerPath": {
118119
"type": "string",
119120
"default": "/usr/local/bin/langserver-swift",
120-
"description": "[DEPRECATED] The fully qualified path to the Swift Language Server executable."
121+
"description": "[DEPRECATED] The fully qualified path to the Swift Language Server executable. Only available in global config for security reasons.",
122+
"scope": "machine"
121123
},
122124
"swift.path.sourcekite": {
123125
"type": "string",
124-
"description": "The fully path to the sourcekite(SDE's LS backend)."
126+
"description": "The fully path to the sourcekite(SDE's LS backend). Only available in global config for security reasons.",
127+
"scope": "machine"
125128
},
126129
"swift.path.sourcekiteDockerMode": {
127130
"type": "boolean",
128131
"default": false,
129-
"description": "[DEPRECATED] (Experimental)Enable to run dedicated docker shell command. It is the responsibility of user to guarantee that the docker cmd 'docker run --rm -i jinmingjian/docker-sourcekite' works in your system."
132+
"description": "[DEPRECATED] (Experimental)Enable to run dedicated docker shell command. It is the responsibility of user to guarantee that the docker cmd 'docker run --rm -i jinmingjian/docker-sourcekite' works in your system.",
133+
"scope": "machine"
130134
},
131135
"swift.path.swift_driver_bin": {
132136
"type": "string",
133137
"default": "/usr/bin/swift",
134-
"description": "The fully path to the swift driver binary."
138+
"description": "The fully path to the swift driver binary. Only available in global config for security reasons.",
139+
"scope": "machine"
135140
},
136141
"swift.path.shell": {
137142
"type": "string",
138143
"default": "/bin/sh",
139-
"description": "The fully path to the shell binary."
144+
"description": "The fully path to the shell binary. Only available in global config for security reasons.",
145+
"scope": "machine"
140146
},
141147
"sde.sourcekit.compilerOptions": {
142148
"type": "array",

0 commit comments

Comments
 (0)