Split out tests for Enum and Variable types

Author: dupski

README.md

@@ -200,7 +200,7 @@ query {
 
 ## TO-DO List
 
- * Fragments
+ * Support Named Queries / Mutations
  * Probably some other things!...
 
 Pull requests welcome!

src/__tests__/jsonToGraphQLQuery.tests.ts

@@ -1,6 +1,6 @@
 
 import { expect } from 'chai';
-import { jsonToGraphQLQuery, EnumType, VariableType } from '../';
+import { jsonToGraphQLQuery } from '../';
 
 describe('jsonToGraphQL()', () => {
 
@@ -66,29 +66,6 @@ describe('jsonToGraphQL()', () => {
 }`);
     });
 
-    it('converts a query with enum arguments', () => {
-      const query = {
-          query: {
-              Posts: {
-                  __args: {
-                      status: new EnumType('PUBLISHED')
-                  },
-                  id: true,
-                  title: true,
-                  post_date: true
-              }
-          }
-      };
-      expect(jsonToGraphQLQuery(query, { pretty: true })).to.equal(
-`query {
-    Posts (status: PUBLISHED) {
-        id
-        title
-        post_date
-    }
-}`);
-  });
-
     it('converts a query with JSON arguments', () => {
         const query = {
             query: {
@@ -305,41 +282,3 @@ describe('jsonToGraphQL()', () => {
       );
     });
 });
-
-it('converts a query variables', () => {
-    const query = {
-        query: {
-            __variables: {
-                variableName: 'String!'
-            },
-            Posts: {
-                __args: {
-                    arg1: 20,
-                    arg2: new VariableType('variableName')
-                },
-                id: true,
-                title: true,
-                comments: {
-                    __args: {
-                        offensiveOnly: true
-                    },
-                    id: true,
-                    comment: true,
-                    user: true
-                }
-            }
-        }
-    };
-    expect(jsonToGraphQLQuery(query, { pretty: true })).to.equal(
-`query ($variableName: String!) {
-    Posts (arg1: 20, arg2: $variableName) {
-        id
-        title
-        comments (offensiveOnly: true) {
-            id
-            comment
-            user
-        }
-    }
-}`);
-});

src/jsonToGraphQLQuery.ts

@@ -1,11 +1,11 @@
-import {EnumType} from './types/EnumType';
-import {VariableType} from './types/VariableType';
+import { EnumType } from './types/EnumType';
+import { VariableType } from './types/VariableType';
 
 function stringify(obj_from_json: any): string {
     if (obj_from_json instanceof EnumType) {
         return obj_from_json.value;
     }
-    // variables should be prefixed with dollar sign and not e quoted
+    // variables should be prefixed with dollar sign and not quoted
     else if (obj_from_json instanceof VariableType) {
         return `$${obj_from_json.value}`;
     }

src/types/__tests__/EnumType.tests.ts

@@ -0,0 +1,30 @@
+
+import { expect } from 'chai';
+import { jsonToGraphQLQuery, EnumType } from '../../';
+
+describe('EnumType()', () => {
+
+    it('converts a query with enum arguments', () => {
+      const query = {
+          query: {
+              Posts: {
+                  __args: {
+                      status: new EnumType('PUBLISHED')
+                  },
+                  id: true,
+                  title: true,
+                  post_date: true
+              }
+          }
+      };
+      expect(jsonToGraphQLQuery(query, { pretty: true })).to.equal(
+`query {
+    Posts (status: PUBLISHED) {
+        id
+        title
+        post_date
+    }
+}`);
+  });
+
+});

src/types/__tests__/VariableType.tests.ts

@@ -0,0 +1,46 @@
+
+import { expect } from 'chai';
+import { jsonToGraphQLQuery, VariableType } from '../../';
+
+describe('VariableType()', () => {
+
+    it('converts query variables', () => {
+        const query = {
+            query: {
+                __variables: {
+                    someString: 'String!',
+                    varWithDefault: 'String = "default_value"'
+                },
+                Posts: {
+                    __args: {
+                        arg1: 20,
+                        arg2: new VariableType('someString')
+                    },
+                    id: true,
+                    title: true,
+                    comments: {
+                        __args: {
+                            offensiveOnly: true
+                        },
+                        id: true,
+                        comment: true,
+                        user: true
+                    }
+                }
+            }
+        };
+        expect(jsonToGraphQLQuery(query, { pretty: true })).to.equal(
+`query ($someString: String!, $varWithDefault: String = "default_value") {
+    Posts (arg1: 20, arg2: $someString) {
+        id
+        title
+        comments (offensiveOnly: true) {
+            id
+            comment
+            user
+        }
+    }
+}`);
+    });
+
+});

tsconfig.json

@@ -8,6 +8,7 @@
         "sourceMap": true,
         "experimentalDecorators": true,
         "removeComments": true,
+        "noUnusedLocals": true,
         "lib": [
             "es2015"
         ]