JsonBinaryType for non serializable types in 3.15

[cigaly]

Latest changes in io.hypersistence.utils.hibernate.type.util.ObjectMapperJsonSerializer are making impossible to clone non serializable object. One of consequences is that io.hypersistence.utils.hibernate.type.json.JsonBinaryType can not handle non serializable types any more.

Example code below will now throw ClassCastException

        Object original = new NonSerializableObject("value");
        final var type = new JsonBinaryType(NonSerializableObject.class);
        final var cloned = type.deepCopy(original);

[vladmihalcea]

Yes, that's by design since the JPA specification does not support non-Serializable attributes, and there were tons of issues caused by this feature. The previous implementation was taking around 1 second for the clone, and the clone might be called multiple times per transaction.

Therefore, it's more efficient to add Serializable to the objects that get persisted to JSON columns. Or, you could also do something like this:

@Column(columnDefinition="jsonb")
private String additionalProperties;

public NonSerializableObject getAdditonalProperties() {
    return convertFromString(additionalProperties);
}

public void setAdditonalProperties(NonSerializableObject props) {
    this.additionalProperties = convertToString(props);
}

[freddiN]

hui, this is quite an unexpected one for us, I started making all DTOs serializable throughout the whole object tree after finding this discussion.

The stacktrace I am seeing (operating on a json database type in mysql 8, spring boot 4.0.2, hibernate 7.2.1) looks like this:

java.lang.ClassCastException: class a.b.c.d.DTO cannot be cast to class java.io.Serializable (a.b.c.d.DTO is in
 unnamed module of loader org.springframework.boot.loader.launch.LaunchedClassLoader @5e2de80c; java.io.Serializable is in module java.base of loader 'bootstrap')
        at io.hypersistence.utils.hibernate.type.util.ObjectMapperJsonSerializer.clone(ObjectMapperJsonSerializer.java:23)
        at io.hypersistence.utils.hibernate.type.util.ObjectMapperWrapper.clone(ObjectMapperWrapper.java:158)
        at io.hypersistence.utils.hibernate.type.json.internal.JsonJavaTypeDescriptor$1.deepCopyNotNull(JsonJavaTypeDescriptor.java:58)
        at org.hibernate.type.descriptor.java.MutableMutabilityPlan.deepCopy(MutableMutabilityPlan.java:48)
        at io.hypersistence.utils.hibernate.type.MutableType.deepCopy(MutableType.java:111)
        at org.hibernate.boot.model.process.internal.UserTypeMutabilityPlanAdapter.deepCopy(UserTypeMutabilityPlanAdapter.java:30)
        at org.hibernate.sql.results.graph.entity.internal.EntityInitializerImpl.deepCopy(EntityInitializerImpl.java:878)
        at org.hibernate.sql.results.graph.entity.internal.EntityInitializerImpl.takeSnapshot(EntityInitializerImpl.java:1697)
        at org.hibernate.sql.results.graph.entity.internal.EntityInitializerImpl.initializeEntityInstance(EntityInitializerImpl.java:1618)
        at org.hibernate.sql.results.graph.entity.internal.EntityInitializerImpl.initializeInstance(EntityInitializerImpl.java:1501)
        at org.hibernate.sql.results.graph.entity.internal.EntityInitializerImpl.initializeInstance(EntityInitializerImpl.java:80)
        at org.hibernate.sql.results.internal.StandardRowReader.coordinateInitializers(StandardRowReader.java:239)
        at org.hibernate.sql.results.internal.StandardRowReader.readRow(StandardRowReader.java:137)
        at org.hibernate.sql.results.spi.ListResultsConsumer.read(ListResultsConsumer.java:243)
        at org.hibernate.sql.results.spi.ListResultsConsumer.readRows(ListResultsConsumer.java:233)
        at org.hibernate.sql.results.spi.ListResultsConsumer.consume(ListResultsConsumer.java:164)
        at org.hibernate.sql.results.spi.ListResultsConsumer.consume(ListResultsConsumer.java:31)
        at org.hibernate.sql.exec.internal.JdbcSelectExecutorStandardImpl.doExecuteQuery(JdbcSelectExecutorStandardImpl.java:211)

Maybe this helps the next person who encounters the same issue.

[vladmihalcea]

@freddiN The exception you got is a ClassLoader issue. Usually, it happens when you have multiple versions of the same DTO class at runtime.

Check out the dependency tree to make sure that you don't inherit the wrong DTO class at runtime.

[freddiN]

@freddiN The exception you got is a ClassLoader issue. Usually, it happens when you have multiple versions of the same DTO class at runtime.

Check out the dependency tree to make sure that you don't inherit the wrong DTO class at runtime.

The class exists only one, nowhere in the project, nor in any depenencies.
Adding serializable to the class (and the whole tree) fixes the issue for me.

Are you absolutely positive its unrelated If so, I would suggest I open a new issue to not pollute this one.

[vladmihalcea]

@freddiN You can open a new issue since a check should be done before calling SerializationHelper.clone.