ci: use ubuntu-latest instead of ubuntu-20.04 (which is now scheduled for retirement) (#160)

Author: spytheman

.github/workflows/analyzer_tests.yml

@@ -27,7 +27,7 @@ jobs:
         include:
           - os: macos-latest
             cc: clang
-          - os: ubuntu-20.04
+          - os: ubuntu-latest
             cc: gcc
           - os: windows-latest
             cc: gcc

.github/workflows/build_ci.yml

@@ -28,7 +28,7 @@ jobs:
   build:
     strategy:
       matrix:
-        os: [ubuntu-20.04, macos-latest, windows-latest]
+        os: [ubuntu-latest, macos-latest, windows-latest]
         mode: [debug, dev, release]
       fail-fast: false
 

.github/workflows/install_ci.yml

@@ -12,7 +12,7 @@ jobs:
   install:
     strategy:
       matrix:
-        os: [ubuntu-20.04, macos-latest, windows-latest]
+        os: [ubuntu-latest, macos-latest, windows-latest]
       fail-fast: false
 
     runs-on: ${{ matrix.os }}

.github/workflows/lint.yml

@@ -18,7 +18,7 @@ concurrency:
 
 jobs:
   fmt:
-    runs-on: ubuntu-20.04
+    runs-on: ubuntu-latest
 
     steps:
       - name: Install V

.github/workflows/release.yml

@@ -33,7 +33,7 @@ jobs:
             os: windows-latest
             bin_ext: .exe
           - target: linux-x86_64
-            os: ubuntu-20.04
+            os: ubuntu-latest
           - target: darwin-x86_64
             os: macos-latest
             vflags: -d cross_compile_macos_x86_64

.github/workflows/version_test.vv

@@ -6,7 +6,14 @@ fn test_version() {
 		eprintln('WARNING: expecting usage in combination with CI workflow.')
 	}
 
-	git_ref := os.getenv('GITHUB_WORKFLOW_SHA').trim_space()[..7]
+	for k, v in os.environ() {
+		println('>>> env key: ${k} | value: ${v}')
+	}
+
+	sha := os.getenv('GITHUB_WORKFLOW_SHA')
+	assert sha.len > 10
+	git_ref := sha.trim_space()[..7]
+
 	manifest := vmod.decode(@VMOD_FILE)!
 	assert manifest.name == 'v-analyzer'
 

build.vsh

@@ -11,9 +11,10 @@ import src.metadata
 
 const vexe = @VEXE
 const bin_path = './bin/v-analyzer' + $if windows { '.exe' } $else { '' }
-const build_commit = os.execute('git rev-parse --short HEAD').output.trim_space()
 const build_time = time.now()
+const build_commit = get_build_commit()
 const build_datetime = build_time.format_ss()
+
 const gcheck = term.bold(term.green('✓'))
 const ynote = term.bold(term.gray('ⓘ '))
 const is_nixos = os.exists('/etc/NIXOS')
@@ -24,6 +25,14 @@ enum ReleaseMode {
 	dev
 }
 
+fn get_build_commit() string {
+	// In pull requests, GA creates a merge commit, to test the latest changes,
+	// as if they would have been merged in the main branch. However for building
+	// and version checking, we need the commit hash of the actual last change in the PR.
+	committish := os.getenv_opt('GITHUB_WORKFLOW_SHA') or { 'HEAD' }
+	return os.execute('git rev-parse --short ${committish}').output.trim_space()
+}
+
 fn eline(msg string) {
 	eprintln('${term.bold(term.red('[ERROR]'))} ${msg}')
 }