Skip to content

[Controller] panic when create kvcache #1110

@yyzxw

Description

@yyzxw

🐛 Describe the bug

use example kvcache yaml create a kvcache, controller-manager was panic.

Steps to Reproduce

apply example kvcache file from: https://github.com/vllm-project/aibrix/blob/main/config/samples/orchestration_v1alpha1_kvcache.yaml

then controller-manager panic, log details:

I0520 11:21:15.502966       1 controller.go:115] "msg"="Observed a panic in reconciler: cannot parse '': quantities must match the regular expression '^([+-]?[0-9.]+)([eEinumkKMGTP]*[-+]?[0-9]*)$'" "KVCache"={"name":"aibrix-deepseek-coder-33b-kvcache","namespace":"aibrix-demo"} "controller"="kv-cache-controller" "controllerGroup"="orchestration.aibrix.ai" "controllerKind"="KVCache" "name"="aibrix-deepseek-coder-33b-kvcache" "namespace"="aibrix-demo" "reconcileID"="8881e4c3-1049-4b1f-b034-15a4604dc024"
panic: cannot parse '': quantities must match the regular expression '^([+-]?[0-9.]+)([eEinumkKMGTP]*[-+]?[0-9]*)$' [recovered]
	panic: cannot parse '': quantities must match the regular expression '^([+-]?[0-9.]+)([eEinumkKMGTP]*[-+]?[0-9]*)$'

goroutine 499 [running]:
sigs.k8s.io/controller-runtime/pkg/internal/controller.(*Controller).Reconcile.func1()
	/go/pkg/mod/sigs.k8s.io/[email protected]/pkg/internal/controller/controller.go:116 +0x1e5
panic({0x1bbc0c0?, 0xc0006aa7e0?})
	/usr/local/go/src/runtime/panic.go:770 +0x132
k8s.io/apimachinery/pkg/api/resource.MustParse({0x0, 0x0})
	/go/pkg/mod/k8s.io/[email protected]/pkg/api/resource/quantity.go:139 +0x173
github.com/aibrix/aibrix/pkg/controller/kvcache.(*KVCacheReconciler).reconcileDeployment(0xc0009dc090, {0x21a30b0, 0xc00159af90}, 0xc0011aa008)
	/workspace/pkg/controller/kvcache/kvcache_controller.go:510 +0xdbc
github.com/aibrix/aibrix/pkg/controller/kvcache.(*KVCacheReconciler).Reconcile(0xc0009dc090, {0x21a30b0, 0xc00159af90}, {{{0xc00088a830?, 0x0?}, {0xc0001e86c0?, 0xc000b99d10?}}})
	/workspace/pkg/controller/kvcache/kvcache_controller.go:167 +0x15c
sigs.k8s.io/controller-runtime/pkg/internal/controller.(*Controller).Reconcile(0x21a74f0?, {0x21a30b0?, 0xc00159af90?}, {{{0xc00088a830?, 0xb?}, {0xc0001e86c0?, 0x0?}}})
	/go/pkg/mod/sigs.k8s.io/[email protected]/pkg/internal/controller/controller.go:119 +0xb7
sigs.k8s.io/controller-runtime/pkg/internal/controller.(*Controller).reconcileHandler(0xc0007ff9a0, {0x21a30e8, 0xc00053c690}, {0x1cc4200, 0xc00101e380})
	/go/pkg/mod/sigs.k8s.io/[email protected]/pkg/internal/controller/controller.go:316 +0x3bc
sigs.k8s.io/controller-runtime/pkg/internal/controller.(*Controller).processNextWorkItem(0xc0007ff9a0, {0x21a30e8, 0xc00053c690})
	/go/pkg/mod/sigs.k8s.io/[email protected]/pkg/internal/controller/controller.go:266 +0x1be
sigs.k8s.io/controller-runtime/pkg/internal/controller.(*Controller).Start.func2.2()
	/go/pkg/mod/sigs.k8s.io/[email protected]/pkg/internal/controller/controller.go:227 +0x79
created by sigs.k8s.io/controller-runtime/pkg/internal/controller.(*Controller).Start.func2 in goroutine 390

Expected behavior

success create kvcache object

Environment

  • AIBrixs Version: v0.2.1
  • Deployment env: Kubebernetes

Metadata

Metadata

Labels

Type

No type

Projects

No projects

Milestone

No milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions