Skip to content

Commit 1f1ce4b

Browse files
kdeleesjmonson
andauthored
Apply suggestions from code review
will test this and then squash with any furhter fixup Co-authored-by: Samuel Monson <[email protected]> Signed-off-by: Elijah DeLee <[email protected]>
1 parent e816a81 commit 1f1ce4b

File tree

1 file changed

+6
-5
lines changed

1 file changed

+6
-5
lines changed

src/guidellm/backend/openai.py

Lines changed: 6 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -94,7 +94,8 @@ def __init__(
9494
extra_query: Optional[dict] = None,
9595
extra_body: Optional[dict] = None,
9696
remove_from_body: Optional[list[str]] = None,
97-
**kwargs,
97+
headers: Optional[dict] = None,
98+
verify: Optional[bool] = None,
9899
):
99100
super().__init__(type_="openai_http")
100101
self._target = target or settings.openai.base_url
@@ -129,9 +130,9 @@ def __init__(
129130
default_headers["OpenAI-Project"] = self.project
130131

131132
# User-provided headers from kwargs or settings override defaults
132-
user_headers = kwargs.pop("headers", settings.openai.headers or {})
133-
default_headers.update(user_headers)
134-
self.headers = default_headers
133+
default_headers.update(settings.openai.headers or {})
134+
default_headers.update(headers)
135+
self.headers = {k: v for k, v in default_headers.items() if v is not None}
135136

136137
self.timeout = timeout if timeout is not None else settings.request_timeout
137138
self.http2 = http2 if http2 is not None else settings.request_http2
@@ -140,7 +141,7 @@ def __init__(
140141
if follow_redirects is not None
141142
else settings.request_follow_redirects
142143
)
143-
self.verify = kwargs.pop("verify", settings.openai.verify)
144+
self.verify = verify or settings.openai.verify
144145
self.max_output_tokens = (
145146
max_output_tokens
146147
if max_output_tokens is not None

0 commit comments

Comments
 (0)