Skip to content

Commit 257cc9e

Browse files
committed
Properly detect if scenario is a Path
1 parent cf31319 commit 257cc9e

File tree

2 files changed

+12
-4
lines changed

2 files changed

+12
-4
lines changed

src/guidellm/__main__.py

Lines changed: 11 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -31,7 +31,13 @@ def cli():
3131
@click.option(
3232
"--scenario",
3333
type=cli_tools.Union(
34-
click.Path(exists=True, readable=True, file_okay=True, dir_okay=False),
34+
click.Path(
35+
exists=True,
36+
readable=True,
37+
file_okay=True,
38+
dir_okay=False,
39+
path_type=Path, # type: ignore[type-var]
40+
),
3541
click.STRING
3642
),
3743
default=None,
@@ -271,9 +277,11 @@ def benchmark(
271277
# If a scenario file was specified read from it
272278
if scenario is None:
273279
_scenario = GenerativeTextScenario.model_validate(overrides)
280+
elif isinstance(scenario, Path):
281+
_scenario = GenerativeTextScenario.from_file(scenario, overrides)
274282
else:
275-
# TODO: Support pre-defined scenarios
276-
_scenario = GenerativeTextScenario.from_file(Path(scenario), overrides)
283+
# TODO: Add support for builtin scenarios
284+
raise NotImplementedError
277285
except ValidationError as e:
278286
errs = e.errors(include_url=False, include_context=True, include_input=True)
279287
param_name = "--" + str(errs[0]["loc"][0]).replace("_", "-")

src/guidellm/utils/cli.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -20,7 +20,7 @@ def set_if_not_default(ctx: click.Context, **kwargs) -> dict[str, Any]:
2020
"""
2121
values = {}
2222
for k, v in kwargs.items():
23-
if ctx.get_parameter_source(k) != click.core.ParameterSource.DEFAULT:
23+
if ctx.get_parameter_source(k) != click.core.ParameterSource.DEFAULT: # type: ignore[attr-defined]
2424
values[k] = v
2525

2626
return values

0 commit comments

Comments
 (0)