Code quality and tests

Author: Dmytro Parfeniuk

pyproject.toml

@@ -127,7 +127,8 @@ ignore = [
     "TCH002",
     "PLW1514", # allow Path.open without encoding
     "RET505", # allow `else` blocks
-    "RET506" # allow `else` blocks
+    "RET506", # allow `else` blocks
+    "C901"  # allow small if/else complexity
 
 ]
 select = [

src/guidellm/executor/profile_generator.py

@@ -162,13 +162,6 @@ def profile_generation_modes(self) -> List[ProfileGenerationMode]:
         if self._mode in ["constant", "poisson"]:
             return [self._mode] * len(self._rates)
 
-        # WIP
-        # if self._mode in ["concurrent"]:
-        #     if self._rates is None:
-        #         raise ValueError("rate ")
-
-        #     return [self._mode] * int(self._rates[0])
-
         raise ValueError(f"Invalid mode: {self._mode}")
 
     def next(self, current_report: TextGenerationBenchmarkReport) -> Optional[Profile]:

src/guidellm/scheduler/base.py

@@ -316,7 +316,8 @@ def _completed(_task: asyncio.Task) -> None:
         if self.mode == "consistent":
             if self.rate is None:
                 raise ValueError(
-                    "The rate must be specified in order to provide concurrent execution"
+                    "The `rate` must be specified in order to provide "
+                    "the concurrent execution"
                 )
             for index, request in enumerate(self.generator):
                 while (index + 1 - completed) >= settings.max_concurrency:

tests/unit/scheduler/test_load_generator.py

@@ -14,17 +14,19 @@ def test_load_generator_mode():
         "constant",
         "poisson",
         "throughput",
+        "consistent",
     }
 
 
 @pytest.mark.smoke()
 @pytest.mark.parametrize(
     ("mode", "rate"),
     [
+        ("synchronous", None),
         ("constant", 10),
         ("poisson", 5),
         ("throughput", None),
-        ("synchronous", None),
+        ("consistent", 2),
     ],
 )
 def test_load_generator_instantiation(mode, rate):