Skip to content

Commit 3057229

Browse files
committed
Address Copilot review
1 parent 4bff34a commit 3057229

File tree

2 files changed

+3
-2
lines changed

2 files changed

+3
-2
lines changed

src/guidellm/benchmark/profile.py

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -398,6 +398,7 @@ class ThroughputProfile(Profile):
398398
description="Maximum number of concurrent requests to schedule",
399399
)
400400
startup_duration: NonNegativeFloat = Field(
401+
default=0.0,
401402
description=(
402403
"Duration in seconds for distributing startup requests "
403404
"before full throughput scheduling"

src/guidellm/benchmark/scenario.py

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -84,7 +84,7 @@ def from_file(cls: type[T], filename: Path, overrides: dict | None = None) -> T:
8484
logger.error(f"Failed to parse {filename} as type {cls.__name__}")
8585
raise ValueError(f"Error when parsing file: {filename}") from e
8686

87-
data.update(overrides)
87+
data.update(overrides or {})
8888
return cls.model_validate(data)
8989

9090
@classmethod
@@ -144,7 +144,7 @@ def enable_scenarios(func: Callable) -> Any:
144144
@wraps(func)
145145
async def decorator(*args, scenario: Scenario | None = None, **kwargs) -> Any:
146146
if scenario is not None:
147-
kwargs.update(**scenario.model_dump())
147+
kwargs.update(scenario.model_dump())
148148
return await func(*args, **kwargs)
149149

150150
# Modify the signature of the decorator to include the `scenario` argument

0 commit comments

Comments
 (0)