Skip to content

Commit 3083e77

Browse files
committed
add missing ref, update to v4 (#224)
Small issue in ui-unit-test job is causing failures across all PRs since we use pull_request_target instead of pull_request for the trigger in development.yml which means that actions run against the workflow in main instead of the workflow files that might have been updated in the PR. The last UI PR was merged and brought in this buggy ui-unit-test job. I also updated the checkout action to v4 since the other non ui jobs are using v4 instead of v3 Ended up updating package-lock as well since I was getting more failures than expected, thought maybe that was the issue. Regardless, this PR passes the checks when I temporarily update the trigger from pull_request_target to pull_request Signed-off-by: dalthecow <[email protected]>
1 parent e7c0274 commit 3083e77

File tree

2 files changed

+0
-166
lines changed

2 files changed

+0
-166
lines changed

.github/workflows/development.yml

Lines changed: 0 additions & 20 deletions
Original file line numberDiff line numberDiff line change
@@ -34,11 +34,6 @@ jobs:
3434
with:
3535
node-version: '22'
3636

37-
- name: Set up Node.js 22
38-
uses: actions/setup-node@v4
39-
with:
40-
node-version: '22'
41-
4237
- name: Install dependencies
4338
run: npm ci
4439

@@ -74,11 +69,6 @@ jobs:
7469
with:
7570
node-version: '22'
7671

77-
- name: Set up Node.js 22
78-
uses: actions/setup-node@v4
79-
with:
80-
node-version: '22'
81-
8272
- name: Install dependencies
8373
run: npm ci
8474

@@ -114,11 +104,6 @@ jobs:
114104
with:
115105
node-version: '22'
116106

117-
- name: Set up Node.js 22
118-
uses: actions/setup-node@v4
119-
with:
120-
node-version: '22'
121-
122107
- name: Install dependencies
123108
run: npm ci
124109

@@ -194,11 +179,6 @@ jobs:
194179
with:
195180
node-version: '22'
196181

197-
- name: Set up Node.js 22
198-
uses: actions/setup-node@v4
199-
with:
200-
node-version: '22'
201-
202182
- name: Install dependencies
203183
run: npm ci
204184

package-lock.json

Lines changed: 0 additions & 146 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

0 commit comments

Comments
 (0)