Skip to content

Commit 408bc58

Browse files
committed
add missing ref, update to v4 (#224)
Small issue in ui-unit-test job is causing failures across all PRs since we use pull_request_target instead of pull_request for the trigger in development.yml which means that actions run against the workflow in main instead of the workflow files that might have been updated in the PR. The last UI PR was merged and brought in this buggy ui-unit-test job. I also updated the checkout action to v4 since the other non ui jobs are using v4 instead of v3 Ended up updating package-lock as well since I was getting more failures than expected, thought maybe that was the issue. Regardless, this PR passes the checks when I temporarily update the trigger from pull_request_target to pull_request Signed-off-by: dalthecow <[email protected]>
1 parent db485e5 commit 408bc58

File tree

2 files changed

+7
-519
lines changed

2 files changed

+7
-519
lines changed

.github/workflows/development.yml

Lines changed: 7 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -29,7 +29,7 @@ jobs:
2929
runs-on: ubuntu-latest
3030
steps:
3131
- name: Check out code
32-
uses: actions/checkout@v3
32+
uses: actions/checkout@v4
3333
with:
3434
ref: "${{ github.event.pull_request.merge_commit_sha }}"
3535

@@ -68,7 +68,7 @@ jobs:
6868
runs-on: ubuntu-latest
6969
steps:
7070
- name: Check out code
71-
uses: actions/checkout@v3
71+
uses: actions/checkout@v4
7272
with:
7373
ref: "${{ github.event.pull_request.merge_commit_sha }}"
7474

@@ -107,7 +107,7 @@ jobs:
107107
runs-on: ubuntu-latest
108108
steps:
109109
- name: Check out code
110-
uses: actions/checkout@v3
110+
uses: actions/checkout@v4
111111
with:
112112
ref: "${{ github.event.pull_request.merge_commit_sha }}"
113113

@@ -146,7 +146,9 @@ jobs:
146146
runs-on: ubuntu-latest
147147
steps:
148148
- name: Check out code
149-
uses: actions/checkout@v3
149+
uses: actions/checkout@v4
150+
with:
151+
ref: "${{ github.event.pull_request.merge_commit_sha }}"
150152

151153
- name: Set up Node.js 22
152154
uses: actions/setup-node@v4
@@ -183,7 +185,7 @@ jobs:
183185
runs-on: ubuntu-latest
184186
steps:
185187
- name: Check out code
186-
uses: actions/checkout@v3
188+
uses: actions/checkout@v4
187189
with:
188190
ref: "${{ github.event.pull_request.merge_commit_sha }}"
189191

0 commit comments

Comments
 (0)