Commit 46a2c1e
authored
[GuideLLM Refactor] Edge case errors (#376)
## Summary
This PR handles errors that occur when there are no successful requests.
There will obviously still be an error, but it will be one that the user
can get useful information from, rather than one that is the inner
workings breaking.
## Details
- Adds default value for an inner data type to allow it to work in this
edge case.
- Adds an error check that creates a runtime error with an explanation
for the failure. The error message can be changed if you would like the
wording changed.
- Fixes a type literal mismatch.
## Test Plan
- Run GuideLLM against a mock server in a way that results in all
requests failing. Like setting the max token value way too small.
---
- [x] "I certify that all code in this PR is my own, except as noted
below."
## Use of AI
- [ ] Includes AI-assisted code completion
- [ ] Includes code generated by an AI application
- [ ] Includes AI-generated tests (NOTE: AI written tests should have a
docstring that includes `## WRITTEN BY AI ##`)
---------
Signed-off-by: Jared O'Connell <[email protected]>1 parent da02ee8 commit 46a2c1e
2 files changed
+4
-3
lines changed| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
441 | 441 | | |
442 | 442 | | |
443 | 443 | | |
444 | | - | |
| 444 | + | |
445 | 445 | | |
446 | 446 | | |
447 | 447 | | |
| |||
473 | 473 | | |
474 | 474 | | |
475 | 475 | | |
476 | | - | |
| 476 | + | |
477 | 477 | | |
478 | 478 | | |
479 | 479 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
680 | 680 | | |
681 | 681 | | |
682 | 682 | | |
| 683 | + | |
| 684 | + | |
683 | 685 | | |
684 | 686 | | |
685 | 687 | | |
| |||
698 | 700 | | |
699 | 701 | | |
700 | 702 | | |
701 | | - | |
702 | 703 | | |
703 | 704 | | |
704 | 705 | | |
| |||
0 commit comments