Skip to content

Commit 618c149

Browse files
kdeleesjmonson
andcommitted
Apply suggestions from code review
will test this and then squash with any furhter fixup Co-authored-by: Samuel Monson <[email protected]> Signed-off-by: Elijah DeLee <[email protected]>
1 parent 53bbac0 commit 618c149

File tree

1 file changed

+6
-5
lines changed

1 file changed

+6
-5
lines changed

src/guidellm/backend/openai.py

Lines changed: 6 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -95,7 +95,8 @@ def __init__(
9595
extra_query: Optional[dict] = None,
9696
extra_body: Optional[dict] = None,
9797
remove_from_body: Optional[list[str]] = None,
98-
**kwargs,
98+
headers: Optional[dict] = None,
99+
verify: Optional[bool] = None,
99100
):
100101
super().__init__(type_="openai_http")
101102
self._target = target or settings.openai.base_url
@@ -130,9 +131,9 @@ def __init__(
130131
default_headers["OpenAI-Project"] = self.project
131132

132133
# User-provided headers from kwargs or settings override defaults
133-
user_headers = kwargs.pop("headers", settings.openai.headers or {})
134-
default_headers.update(user_headers)
135-
self.headers = default_headers
134+
default_headers.update(settings.openai.headers or {})
135+
default_headers.update(headers)
136+
self.headers = {k: v for k, v in default_headers.items() if v is not None}
136137

137138
self.timeout = timeout if timeout is not None else settings.request_timeout
138139
self.http2 = http2 if http2 is not None else settings.request_http2
@@ -141,7 +142,7 @@ def __init__(
141142
if follow_redirects is not None
142143
else settings.request_follow_redirects
143144
)
144-
self.verify = kwargs.pop("verify", settings.openai.verify)
145+
self.verify = verify or settings.openai.verify
145146
self.max_output_tokens = (
146147
max_output_tokens
147148
if max_output_tokens is not None

0 commit comments

Comments
 (0)