add strategy label to tooltip

Signed-off-by: dalthecow <[email protected]>

Author: DaltheCow

src/guidellm/presentation/data_models.py

@@ -3,6 +3,7 @@
 from math import ceil
 from typing import TYPE_CHECKING, Optional, Union
 
+from guidellm.scheduler.strategy import SchedulingStrategy
 from pydantic import BaseModel, computed_field
 
 if TYPE_CHECKING:
@@ -212,11 +213,26 @@ class BenchmarkDatum(BaseModel):
     ttft: TabularDistributionSummary
     throughput: TabularDistributionSummary
     time_per_request: TabularDistributionSummary
+    strategy_display_str: str
+
+    def strategy_display_str(strategy: SchedulingStrategy):
+        strategy_type = strategy if isinstance(strategy, str) else strategy.type_
+        strategy_instance = strategy if isinstance(strategy, SchedulingStrategy) else None
+
+        if strategy_type == "concurrent":
+            rate = f"@{strategy_instance.streams}" if strategy_instance else "@##"  # type: ignore[attr-defined]
+        elif strategy_type in ("constant", "poisson"):
+            rate = f"@{strategy_instance.rate:.2f}" if strategy_instance else "@#.##"  # type: ignore[attr-defined]
+        else:
+            rate = ""
+        return f"{strategy_type}{rate}"
 
     @classmethod
     def from_benchmark(cls, bm: "GenerativeBenchmark"):
+        rps = bm.metrics.requests_per_second.successful.mean
         return cls(
-            requests_per_second=bm.metrics.requests_per_second.successful.mean,
+            strategy_display_str=cls.strategy_display_str(bm.args.strategy),
+            requests_per_second=rps,
             tpot=TabularDistributionSummary.from_distribution_summary(
                 bm.metrics.inter_token_latency_ms.successful
             ),

src/ui/lib/components/Charts/MetricLine/MetricLine.component.tsx

@@ -1,10 +1,9 @@
 import { Typography, useTheme } from '@mui/material';
-import { ResponsiveLine } from '@nivo/line';
+import { PointTooltipProps, ResponsiveLine } from '@nivo/line';
 import { BasicTooltip } from '@nivo/tooltip';
 import React, { FC } from 'react';
 
 import { useColor } from '@/lib/hooks/useColor';
-import { formatNumber } from '@/lib/utils/helpers';
 
 import { MetricLineProps } from '.';
 import CustomAxes from './components/CustomAxes';
@@ -51,16 +50,12 @@ export const Component: FC<MetricLineProps> = ({
       reverse: false,
     };
   }
-
-  const getUnits = (seriesId: string) => {
-    switch (seriesId) {
-      case 'timePerRequest':
-        return 's';
-      case 'throughput':
-        return 'tok/s';
-      default:
-        return 'ms';
-    }
+  type PointTooltipPropsWithLabel = PointTooltipProps & {
+    point: {
+      data: {
+        label: string;
+      };
+    };
   };
 
   return (
@@ -71,7 +66,7 @@ export const Component: FC<MetricLineProps> = ({
         <BasicTooltip
           id={
             <Typography variant="body2">
-              {`${formatNumber(Number(point.point.data.x))} rps, ${formatNumber(Number(point.point.data.y))} ${getUnits(`${point.point.serieId}`)}`}
+              {(point as PointTooltipPropsWithLabel).point.data.label}
             </Typography>
           }
           color={point.point.color}

src/ui/lib/store/benchmarksWindowData.ts

@@ -1,5 +1,6 @@
 export const benchmarksScript = `window.benchmarks = [
   {
+    strategyDisplayStr: "synchronous",
     requestsPerSecond: 11.411616848282272,
     tpot: {
       mean: 8.758024845683707,
@@ -171,6 +172,7 @@ export const benchmarksScript = `window.benchmarks = [
     },
   },
   {
+    strategyDisplayStr: "[email protected]",
     requestsPerSecond: 36.289181300710815,
     tpot: {
       mean: 588.0161376137819,
@@ -342,6 +344,7 @@ export const benchmarksScript = `window.benchmarks = [
     },
   },
   {
+    strategyDisplayStr: "[email protected]",
     requestsPerSecond: 20.752070927855794,
     tpot: {
       mean: 116.28360712595156,
@@ -513,6 +516,7 @@ export const benchmarksScript = `window.benchmarks = [
     },
   },
   {
+    strategyDisplayStr: "[email protected]",
     requestsPerSecond: 26.81917480361788,
     tpot: {
       mean: 299.7306064613554,
@@ -684,6 +688,7 @@ export const benchmarksScript = `window.benchmarks = [
     },
   },
   {
+    strategyDisplayStr: "[email protected]",
     requestsPerSecond: 26.823988819498975,
     tpot: {
       mean: 683.8011571339198,
@@ -855,6 +860,7 @@ export const benchmarksScript = `window.benchmarks = [
     },
   },
   {
+    strategyDisplayStr: "[email protected]",
     requestsPerSecond: 24.50047903792646,
     tpot: {
       mean: 742.9258901891964,
@@ -1026,6 +1032,7 @@ export const benchmarksScript = `window.benchmarks = [
     },
   },
   {
+    strategyDisplayStr: "[email protected]",
     requestsPerSecond: 25.617829792196602,
     tpot: {
       mean: 663.3098317044122,
@@ -1197,6 +1204,7 @@ export const benchmarksScript = `window.benchmarks = [
     },
   },
   {
+    strategyDisplayStr: "[email protected]",
     requestsPerSecond: 37.02892550982192,
     tpot: {
       mean: 606.4144710877113,
@@ -1368,6 +1376,7 @@ export const benchmarksScript = `window.benchmarks = [
     },
   },
   {
+    strategyDisplayStr: "[email protected]",
     requestsPerSecond: 37.29183354201869,
     tpot: {
       mean: 603.3237551205925,
@@ -1539,6 +1548,7 @@ export const benchmarksScript = `window.benchmarks = [
     },
   },
   {
+    strategyDisplayStr: "throughput",
     requestsPerSecond: 37.45318312972309,
     tpot: {
       mean: 600.7204526769262,

src/ui/lib/store/slices/benchmarks/benchmarks.interfaces.ts

@@ -27,6 +27,7 @@ export interface BenchmarkMetrics {
 
 export interface Benchmark extends BenchmarkMetrics {
   requestsPerSecond: number;
+  strategyDisplayStr: string;
 }
 
 export type Benchmarks = Benchmark[];

src/ui/lib/store/slices/benchmarks/benchmarks.selectors.ts

@@ -18,8 +18,10 @@ export const selectMetricsSummaryLineData = createSelector(
       ?.slice()
       ?.sort((bm1, bm2) => (bm1.requestsPerSecond > bm2.requestsPerSecond ? 1 : -1));
     const selectedPercentile = sloState.enforcedPercentile;
-
-    const lineData: { [K in keyof BenchmarkMetrics]: Point[] } = {
+    interface PointWithLabel extends Point {
+      label: string;
+    }
+    const lineData: { [K in keyof BenchmarkMetrics]: PointWithLabel[] } = {
       ttft: [],
       tpot: [],
       timePerRequest: [],
@@ -32,14 +34,15 @@ export const selectMetricsSummaryLineData = createSelector(
       'throughput',
     ];
     metrics.forEach((metric) => {
-      const data: Point[] = [];
+      const data: PointWithLabel[] = [];
       sortedByRPS?.forEach((benchmark) => {
         const percentile = benchmark[metric].percentileRows.find(
           (p) => p.percentile === selectedPercentile
         );
         data.push({
           x: benchmark.requestsPerSecond,
           y: percentile?.value ?? 0,
+          label: benchmark.strategyDisplayStr,
         });
       });