Switch CMD str to vector

Author: sjmonson

build/entrypoint.sh

@@ -1,29 +1,30 @@
 #!/usr/bin/env bash
 set -euo pipefail
 
+# Path to the guidellm binary
+guidellm_bin="/opt/guidellm/bin/guidellm"
+
 # If we receive any arguments switch to guidellm command
 if [ $# -gt 0 ]; then
     echo "Running command: guidellm $*"
-    exec guidellm "$@"
+    exec $guidellm_bin "$@"
 fi
 
-# Build the command
-CMD="guidellm benchmark --target \"${TARGET}\" --model \"${MODEL}\" --rate-type \"${RATE_TYPE}\" --data \"${DATA}\""
+# NOTE: Bash vec + exec prevent shell escape issues
+CMD=("${guidellm_bin}" "benchmark" "--target" "${TARGET}" "--model" "${MODEL}" "--rate-type" "${RATE_TYPE}" "--data" "${DATA}")
 
-# Add optional parameters
-if [ ! -z "${MAX_REQUESTS}" ]; then
-    CMD="${CMD} --max-requests ${MAX_REQUESTS}"
+if [ -n "${MAX_REQUESTS}" ]; then
+    CMD+=("--max-requests" "${MAX_REQUESTS}")
 fi
 
-if [ ! -z "${MAX_SECONDS}" ]; then
-    CMD="${CMD} --max-seconds ${MAX_SECONDS}"
+if [ -n "${MAX_SECONDS}" ]; then
+    CMD+=("--max-seconds" "${MAX_SECONDS}")
 fi
 
-# Add output path with appropriate extension
-if [ ! -z "${OUTPUT_PATH}" ]; then
-    CMD="${CMD} --output-path \"${OUTPUT_PATH}\""
+if [ -n "${OUTPUT_PATH}" ]; then
+    CMD+=("--output-path" "${OUTPUT_PATH}")
 fi
 
 # Execute the command
-echo "Running command: ${CMD}"
-eval "${CMD}"
+echo "Running command: ${CMD[*]}"
+exec "${CMD[@]}"