Skip to content

Commit ab05120

Browse files
committed
More layer cleanup
Signed-off-by: Samuel Monson <[email protected]>
1 parent ea460f3 commit ab05120

File tree

1 file changed

+6
-5
lines changed

1 file changed

+6
-5
lines changed

Containerfile

Lines changed: 6 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -13,18 +13,18 @@ FROM $BASE_IMAGE as builder
1313
# Ensure files are installed as root
1414
USER root
1515

16-
# Set correct build type for versioning
17-
ENV GUIDELLM_BUILD_TYPE=$GUIDELLM_BUILD_TYPE
18-
1916
# Install build tooling
2017
RUN apt-get update \
2118
&& apt-get install -y --no-install-recommends git \
2219
&& pip install --no-cache-dir -U pdm
2320

24-
# disable pdm update check
25-
ENV PDM_CHECK_UPDATE=false
21+
# Disable pdm update check
22+
# Set correct build type for versioning
23+
ENV PDM_CHECK_UPDATE=false \
24+
GUIDELLM_BUILD_TYPE=$GUIDELLM_BUILD_TYPE
2625

2726
# Copy repository files
27+
# Do this as late as possible to leverage layer caching
2828
COPY / /opt/app-root/src
2929

3030
# Create a venv and install guidellm
@@ -58,6 +58,7 @@ LABEL org.opencontainers.image.source="https://github.com/vllm-project/guidellm"
5858
org.opencontainers.image.description="GuideLLM Performance Benchmarking Container"
5959

6060
# Copy the virtual environment from the builder stage
61+
# Do this as late as possible to leverage layer caching
6162
COPY --from=builder /opt/app-root/guidellm /opt/app-root/guidellm
6263

6364
ENTRYPOINT [ "/opt/app-root/guidellm/bin/guidellm" ]

0 commit comments

Comments
 (0)