Skip to content

Commit b123d15

Browse files
committed
Fix backend tests
Signed-off-by: Samuel Monson <[email protected]>
1 parent a34e566 commit b123d15

File tree

5 files changed

+5
-4
lines changed

5 files changed

+5
-4
lines changed

src/guidellm/scheduler/objects.py

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -20,6 +20,7 @@
2020
Protocol,
2121
TypeVar,
2222
Union,
23+
runtime_checkable,
2324
)
2425

2526
from pydantic import Field, computed_field
@@ -232,6 +233,7 @@ def model_copy(self, **kwargs) -> ScheduledRequestInfo: # type: ignore[override
232233
)
233234

234235

236+
@runtime_checkable
235237
class BackendInterface(Protocol, Generic[RequestT, ResponseT]):
236238
"""
237239
Abstract interface for request processing backends.
File renamed without changes.

tests/unit/backend/test_backend.py renamed to tests/unit/backends/test_backend.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -80,7 +80,7 @@ async def default_model(self) -> str | None:
8080
def test_class_signatures(self):
8181
"""Test Backend inheritance and type relationships."""
8282
assert issubclass(Backend, RegistryMixin)
83-
assert issubclass(Backend, BackendInterface)
83+
assert isinstance(Backend, BackendInterface)
8484
assert hasattr(Backend, "create")
8585
assert hasattr(Backend, "register")
8686
assert hasattr(Backend, "get_registered_object")

tests/unit/backend/test_objects.py renamed to tests/unit/backends/test_objects.py

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -397,7 +397,6 @@ def valid_instances(self, request):
397397
def test_class_signatures(self):
398398
"""Test GenerationRequestTimings inheritance and type relationships."""
399399
assert issubclass(GenerationRequestTimings, MeasuredRequestTimings)
400-
assert issubclass(GenerationRequestTimings, StandardBaseModel)
401400
assert hasattr(GenerationRequestTimings, "model_dump")
402401
assert hasattr(GenerationRequestTimings, "model_validate")
403402

tests/unit/backend/test_openai_backend.py renamed to tests/unit/backends/test_openai_backend.py

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -237,7 +237,7 @@ async def test_info(self):
237237
target="http://test", model="test-model", timeout=30.0
238238
)
239239

240-
info = backend.info()
240+
info = backend.info
241241

242242
assert info["target"] == "http://test"
243243
assert info["model"] == "test-model"
@@ -1074,7 +1074,7 @@ def test_get_chat_message_media_item_jpeg_file(self):
10741074
mock_image = Mock(spec=Image.Image)
10751075
mock_image.tobytes.return_value = b"fake_jpeg_data"
10761076

1077-
with patch("guidellm.backend.openai.Image.open", return_value=mock_image):
1077+
with patch("guidellm.backends.openai.Image.open", return_value=mock_image):
10781078
result = backend._get_chat_message_media_item(mock_jpeg_path)
10791079

10801080
expected_data = base64.b64encode(b"fake_jpeg_data").decode("utf-8")

0 commit comments

Comments
 (0)