Skip to content

Commit b1b1b78

Browse files
authored
update default build values to use versioned builds (#310)
## Summary With the default path referring to the versioned build now, users will no longer experience their html reports breaking randomly when the build files are updated. Also fixed versioned build directory path issue that I missed previously --------- Signed-off-by: dalthecow <[email protected]>
1 parent 5c9982a commit b1b1b78

File tree

4 files changed

+7
-7
lines changed

4 files changed

+7
-7
lines changed

.github/workflows/release-candidate.yml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -228,7 +228,7 @@ jobs:
228228
uses: peaceiris/actions-gh-pages@v3
229229
with:
230230
github_token: ${{ secrets.GITHUB_TOKEN }}
231-
publish_dir: ./ui/out
231+
publish_dir: .src/ui/out
232232
destination_dir: ui/release/${TAG}
233233
keep_files: false
234234
user_name: ${{ github.actor }}

.github/workflows/release.yml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -227,7 +227,7 @@ jobs:
227227
uses: peaceiris/actions-gh-pages@v3
228228
with:
229229
github_token: ${{ secrets.GITHUB_TOKEN }}
230-
publish_dir: ./ui/out
230+
publish_dir: ./src/ui/out
231231
destination_dir: ui/${TAG}
232232
keep_files: false
233233
user_name: ${{ github.actor }}

src/guidellm/config.py

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -31,8 +31,8 @@ class Environment(str, Enum):
3131

3232

3333
ENV_REPORT_MAPPING = {
34-
Environment.PROD: "https://blog.vllm.ai/guidellm/ui/latest/index.html",
35-
Environment.STAGING: "https://blog.vllm.ai/guidellm/ui/release/latest/index.html",
34+
Environment.PROD: "https://blog.vllm.ai/guidellm/ui/v0.3.0/index.html",
35+
Environment.STAGING: "https://blog.vllm.ai/guidellm/ui/release/v0.3.0/index.html",
3636
Environment.DEV: "https://blog.vllm.ai/guidellm/ui/dev/index.html",
3737
Environment.LOCAL: "http://localhost:3000/index.html",
3838
}

tests/unit/test_config.py

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -21,7 +21,7 @@ def test_default_settings():
2121
assert settings.openai == OpenAISettings()
2222
assert (
2323
settings.report_generation.source
24-
== "https://blog.vllm.ai/guidellm/ui/latest/index.html"
24+
== "https://blog.vllm.ai/guidellm/ui/v0.3.0/index.html"
2525
)
2626

2727

@@ -60,13 +60,13 @@ def test_report_generation_default_source():
6060
settings = Settings(env=Environment.STAGING)
6161
assert (
6262
settings.report_generation.source
63-
== "https://blog.vllm.ai/guidellm/ui/release/latest/index.html"
63+
== "https://blog.vllm.ai/guidellm/ui/release/v0.3.0/index.html"
6464
)
6565

6666
settings = Settings(env=Environment.PROD)
6767
assert (
6868
settings.report_generation.source
69-
== "https://blog.vllm.ai/guidellm/ui/latest/index.html"
69+
== "https://blog.vllm.ai/guidellm/ui/v0.3.0/index.html"
7070
)
7171

7272

0 commit comments

Comments
 (0)