Skip to content

Commit b5ba4b0

Browse files
fix: E2E tests
Signed-off-by: Alon Kellner <[email protected]>
1 parent 8a4b343 commit b5ba4b0

File tree

3 files changed

+10
-10
lines changed

3 files changed

+10
-10
lines changed

tests/e2e/utils.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -70,7 +70,7 @@ def start_benchmark(
7070
cmd_parts = [
7171
*([f"{k}={v}" for k, v in extra_env.items()] if extra_env else []),
7272
"HF_HOME=/tmp/huggingface_cache",
73-
f"{guidellm_exe} benchmark",
73+
f"{guidellm_exe} benchmark run",
7474
f'--target "{self.target}"',
7575
f"--profile {profile}",
7676
f"--rate {rate}",

tests/unit/scheduler/test_over_saturation.py

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -362,13 +362,13 @@ def test_initialization_valid(self, valid_instances):
362362
@pytest.mark.sanity
363363
def test_initialization_invalid(self):
364364
"""Test that initializer rejects invalid parameters."""
365-
# Missing required field
365+
# Invalid type for enabled
366366
with pytest.raises(ValidationError):
367-
OverSaturationConstraintInitializer()
367+
OverSaturationConstraintInitializer(enabled="invalid")
368368

369-
# Invalid type
369+
# Invalid type for min_seconds
370370
with pytest.raises(ValidationError):
371-
OverSaturationConstraintInitializer(enabled="invalid", type_="invalid")
371+
OverSaturationConstraintInitializer(enabled=True, min_seconds="invalid")
372372

373373
@pytest.mark.smoke
374374
def test_create_constraint(self, valid_instances):

tests/unit/scheduler/test_over_saturation_comprehensive.py

Lines changed: 5 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -502,9 +502,9 @@ def test_constraint_with_realistic_request_flow(self):
502502
@pytest.mark.sanity
503503
def test_constraint_disabled_never_stops(self):
504504
"""Test that disabled constraint never stops regardless of load."""
505-
detector = OverSaturationConstraint(minimum_duration=0.0, minimum_window_size=3)
506505
constraint = OverSaturationConstraint(
507-
detector,
506+
minimum_duration=0.0,
507+
minimum_window_size=3,
508508
enabled=False, # Disabled
509509
)
510510

@@ -608,8 +608,8 @@ def test_initializer_parameter_validation(self):
608608

609609
constraint = initializer.create_constraint()
610610
assert constraint.enabled is True
611-
assert constraint.over_saturation_constraint.minimum_duration == 5.0
612-
assert constraint.over_saturation_constraint.maximum_window_seconds == 30.0
611+
assert constraint.minimum_duration == 5.0
612+
assert constraint.maximum_window_seconds == 30.0
613613

614614
@pytest.mark.smoke
615615
def test_initializer_with_extreme_parameters(self):
@@ -708,7 +708,7 @@ def test_detector_with_malformed_request_data(self):
708708
def test_constraint_with_missing_timings_data(self):
709709
"""Test constraint handles missing timings data gracefully."""
710710
constraint = OverSaturationConstraint(
711-
OverSaturationConstraint(minimum_duration=0.0),
711+
minimum_duration=0.0,
712712
enabled=True,
713713
)
714714

0 commit comments

Comments
 (0)