Consolidate quality jobs

Signed-off-by: Samuel Monson <[email protected]>

Author: sjmonson

.github/workflows/development.yml

@@ -17,117 +17,19 @@ jobs:
   ui-tests:
     uses: ./.github/workflows/testing-ui.yml
 
-  quality-checks:
-    runs-on: ubuntu-latest
-    strategy:
-      matrix:
-        python: ["3.10", "3.13"]
-    steps:
-      - uses: actions/checkout@v4
-      - name: Set up Python
-        uses: actions/setup-python@v5
-        with:
-          python-version: ${{ matrix.python }}
-      - name: Install dependencies
-        run: |
-          curl -sSL https://pdm-project.org/install-pdm.py | python3 -
-          pip install tox tox-pdm
-      - name: Run quality checks
-        run: tox -e quality
-
-  ui-quality-checks:
-    permissions:
-      contents: "read"
-    runs-on: ubuntu-latest
-    steps:
-      - name: Check out code
-        uses: actions/checkout@v4
-
-      - name: Set up Node.js 22
-        uses: actions/setup-node@v4
-        with:
-          node-version: '22'
-
-      - name: Install dependencies
-        run: npm ci
-
-      - name: Run quality and typing checks
-        run: npm run lint
-
-  type-checks:
-    runs-on: ubuntu-latest
+  quality:
     strategy:
       matrix:
         python: ["3.10", "3.13"]
-    steps:
-      - uses: actions/checkout@v4
-      - name: Set up Python
-        uses: actions/setup-python@v5
-        with:
-          python-version: ${{ matrix.python }}
-      - name: Install dependencies
-        run: |
-          curl -sSL https://pdm-project.org/install-pdm.py | python3 -
-          pip install tox tox-pdm
-      - name: Run quality checks
-        run: tox -e types
-
-  ui-type-checks:
-    permissions:
-      contents: "read"
-    runs-on: ubuntu-latest
-    steps:
-      - name: Check out code
-        uses: actions/checkout@v4
-
-      - name: Set up Node.js 22
-        uses: actions/setup-node@v4
-        with:
-          node-version: '22'
-
-      - name: Install dependencies
-        run: npm ci
-
-      - name: Run quality and typing checks
-        run: npm run type-check
-
-  precommit-checks:
-    runs-on: ubuntu-latest
-    strategy:
-      matrix:
-        python: ["3.10"]
-    steps:
-      - uses: actions/checkout@v4
-      - name: Set up Python
-        uses: actions/setup-python@v5
-        with:
-          python-version: ${{ matrix.python }}
-      - name: Install dependencies
-        run: pip install pre-commit
-      - name: Run pre-commit checks
-        run: SKIP=ruff-format pre-commit run --all-files
-
-  ui-precommit-checks:
-    permissions:
-      contents: "read"
-    runs-on: ubuntu-latest
-    steps:
-      - name: Check out code
-        uses: actions/checkout@v4
-
-      - name: Set up Node.js 22
-        uses: actions/setup-node@v4
-        with:
-          node-version: '22'
-
-      - name: Install dependencies
-        run: npm ci
+    uses: ./.github/workflows/quality.yml
+    with:
+      python: ${{ matrix.python }}
 
-      - name: Run pre-commit checks
-        run: npx husky run pre-commit
+  ui-quality:
+    uses: ./.github/workflows/ui-quality.yml
 
   ui-pr-preview:
-    needs: [ui-quality-checks, ui-precommit-checks, ui-tests]
+    needs: [ui-quality, ui-tests]
     permissions:
       contents: write
       pull-requests: write

.github/workflows/main.yml

@@ -17,117 +17,19 @@ jobs:
   ui-tests:
     uses: ./.github/workflows/testing-ui.yml
 
-  quality-checks:
-    runs-on: ubuntu-latest
-    strategy:
-      matrix:
-        python: ["3.10", "3.11", "3.12", "3.13"]
-    steps:
-      - uses: actions/checkout@v4
-      - name: Set up Python
-        uses: actions/setup-python@v5
-        with:
-          python-version: ${{ matrix.python }}
-      - name: Install dependencies
-        run: |
-          curl -sSL https://pdm-project.org/install-pdm.py | python3 -
-          pip install tox tox-pdm
-      - name: Run quality checks
-        run: tox -e quality
-
-  ui-quality-checks:
-    permissions:
-      contents: "read"
-    runs-on: ubuntu-latest
-    steps:
-      - name: Check out code
-        uses: actions/checkout@v3
-
-      - name: Set up Node.js 22
-        uses: actions/setup-node@v4
-        with:
-          node-version: '22'
-
-      - name: Install dependencies
-        run: npm ci
-
-      - name: Run quality and typing checks
-        run: npm run lint
-
-  type-checks:
-    runs-on: ubuntu-latest
+  quality:
     strategy:
       matrix:
         python: ["3.10", "3.11", "3.12", "3.13"]
-    steps:
-      - uses: actions/checkout@v4
-      - name: Set up Python
-        uses: actions/setup-python@v5
-        with:
-          python-version: ${{ matrix.python }}
-      - name: Install dependencies
-        run: |
-          curl -sSL https://pdm-project.org/install-pdm.py | python3 -
-          pip install tox tox-pdm
-      - name: Run quality checks
-        run: tox -e types
-
-  ui-type-checks:
-    permissions:
-      contents: "read"
-    runs-on: ubuntu-latest
-    steps:
-      - name: Check out code
-        uses: actions/checkout@v3
-
-      - name: Set up Node.js 22
-        uses: actions/setup-node@v4
-        with:
-          node-version: '22'
-
-      - name: Install dependencies
-        run: npm ci
-
-      - name: Run quality and typing checks
-        run: npm run type-check
-
-  precommit-checks:
-    runs-on: ubuntu-latest
-    strategy:
-      matrix:
-        python: ["3.10"]
-    steps:
-      - uses: actions/checkout@v4
-      - name: Set up Python
-        uses: actions/setup-python@v5
-        with:
-          python-version: ${{ matrix.python }}
-      - name: Install dependencies
-        run: pip install pre-commit
-      - name: Run pre-commit checks
-        run: SKIP=ruff-format pre-commit run --all-files
-
-  ui-precommit-checks:
-    permissions:
-      contents: "read"
-    runs-on: ubuntu-latest
-    steps:
-      - name: Check out code
-        uses: actions/checkout@v3
-
-      - name: Set up Node.js 22
-        uses: actions/setup-node@v4
-        with:
-          node-version: '22'
-
-      - name: Install dependencies
-        run: npm ci
+    uses: ./.github/workflows/quality.yml
+    with:
+      python: ${{ matrix.python }}
 
-      - name: Run pre-commit checks
-        run: npx husky run pre-commit
+  ui-quality:
+    uses: ./.github/workflows/ui-quality.yml
 
   deploy-ui-build:
-    needs: [ui-quality-checks, ui-precommit-checks, ui-tests]
+    needs: [ui-quality, ui-tests]
     permissions:
       contents: write
     runs-on: ubuntu-latest

.github/workflows/quality.yml

@@ -0,0 +1,55 @@
+name: Quality Checks
+
+on:
+  workflow_call:
+    inputs:
+      python:
+        required: true
+        type: string
+
+jobs:
+  quality-checks:
+    runs-on: ubuntu-latest
+    steps:
+      - uses: actions/checkout@v4
+      - name: Set up Python
+        uses: actions/setup-python@v5
+        with:
+          python-version: ${{ inputs.python }}
+      - name: Install dependencies
+        run: |
+          curl -sSL https://pdm-project.org/install-pdm.py | python3 -
+          pip install tox tox-pdm
+      - name: Run quality checks
+        run: tox -e quality
+
+  type-checks:
+    runs-on: ubuntu-latest
+    steps:
+      - uses: actions/checkout@v4
+      - name: Set up Python
+        uses: actions/setup-python@v5
+        with:
+          python-version: ${{ inputs.python }}
+      - name: Install dependencies
+        run: |
+          curl -sSL https://pdm-project.org/install-pdm.py | python3 -
+          pip install tox tox-pdm
+      - name: Run quality checks
+        run: tox -e types
+
+  precommit-checks:
+    runs-on: ubuntu-latest
+    strategy:
+      matrix:
+        python: ["3.10"]
+    steps:
+      - uses: actions/checkout@v4
+      - name: Set up Python
+        uses: actions/setup-python@v5
+        with:
+          python-version: ${{ matrix.python }}
+      - name: Install dependencies
+        run: pip install pre-commit
+      - name: Run pre-commit checks
+        run: SKIP=ruff-format pre-commit run --all-files

.github/workflows/ui-quality.yml

@@ -0,0 +1,62 @@
+name: UI Quality Checks
+
+on:
+  workflow_call:
+
+jobs:
+  ui-quality-checks:
+    permissions:
+      contents: "read"
+    runs-on: ubuntu-latest
+    steps:
+      - name: Check out code
+        uses: actions/checkout@v4
+
+      - name: Set up Node.js 22
+        uses: actions/setup-node@v4
+        with:
+          node-version: '22'
+
+      - name: Install dependencies
+        run: npm ci
+
+      - name: Run quality and typing checks
+        run: npm run lint
+
+  ui-type-checks:
+    permissions:
+      contents: "read"
+    runs-on: ubuntu-latest
+    steps:
+      - name: Check out code
+        uses: actions/checkout@v4
+
+      - name: Set up Node.js 22
+        uses: actions/setup-node@v4
+        with:
+          node-version: '22'
+
+      - name: Install dependencies
+        run: npm ci
+
+      - name: Run quality and typing checks
+        run: npm run type-check
+
+  ui-precommit-checks:
+    permissions:
+      contents: "read"
+    runs-on: ubuntu-latest
+    steps:
+      - name: Check out code
+        uses: actions/checkout@v4
+
+      - name: Set up Node.js 22
+        uses: actions/setup-node@v4
+        with:
+          node-version: '22'
+
+      - name: Install dependencies
+        run: npm ci
+
+      - name: Run pre-commit checks
+        run: npx husky run pre-commit