Skip to content

Commit c11cc7f

Browse files
committed
Move CLI and output options out of scenario
1 parent 06e6ff0 commit c11cc7f

File tree

2 files changed

+6
-15
lines changed

2 files changed

+6
-15
lines changed

src/guidellm/__main__.py

Lines changed: 6 additions & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -214,19 +214,16 @@ def cli():
214214
@click.option(
215215
"--disable-progress",
216216
is_flag=True,
217-
default=not GenerativeTextScenario.model_fields["show_progress"].default,
218217
help="Set this flag to disable progress updates to the console",
219218
)
220219
@click.option(
221220
"--display-scheduler-stats",
222221
is_flag=True,
223-
default=GenerativeTextScenario.model_fields["show_progress_scheduler_stats"].default,
224222
help="Set this flag to display stats for the processes running the benchmarks",
225223
)
226224
@click.option(
227225
"--disable-console-outputs",
228226
is_flag=True,
229-
default=not GenerativeTextScenario.model_fields["output_console"].default,
230227
help="Set this flag to disable console output",
231228
)
232229
@click.option(
@@ -243,7 +240,6 @@ def cli():
243240
@click.option(
244241
"--output-extras",
245242
callback=parse_json,
246-
default=GenerativeTextScenario.model_fields["output_extras"].default,
247243
help="A JSON string of extra data to save with the output benchmarks",
248244
)
249245
@click.option(
@@ -316,18 +312,18 @@ def benchmark(
316312
max_requests=max_requests,
317313
warmup_percent=warmup_percent,
318314
cooldown_percent=cooldown_percent,
319-
show_progress=not disable_progress,
320-
show_progress_scheduler_stats=display_scheduler_stats,
321-
output_console=not disable_console_outputs,
322-
output_path=output_path,
323-
output_extras=output_extras,
324315
output_sampling=output_sampling,
325316
random_seed=random_seed,
326317
))
327318

328319
asyncio.run(
329320
benchmark_with_scenario(
330-
scenario=GenerativeTextScenario(**_scenario)
321+
scenario=GenerativeTextScenario(**_scenario),
322+
show_progress=not disable_progress,
323+
show_progress_scheduler_stats=display_scheduler_stats,
324+
output_console=not disable_console_outputs,
325+
output_path=output_path,
326+
output_extras=output_extras,
331327
)
332328
)
333329

src/guidellm/benchmark/scenario.py

Lines changed: 0 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -57,10 +57,5 @@ class Config:
5757
max_requests: Optional[int] = None
5858
warmup_percent: Optional[float] = None
5959
cooldown_percent: Optional[float] = None
60-
show_progress: bool = True
61-
show_progress_scheduler_stats: bool = True
62-
output_console: bool = True
63-
output_path: Optional[Union[str, Path]] = None
64-
output_extras: Optional[dict[str, Any]] = None
6560
output_sampling: Optional[int] = None
6661
random_seed: int = 42

0 commit comments

Comments
 (0)