Skip to content

Commit c48c9cf

Browse files
authored
fix inconsistent use of abbreviations in ui (#388)
## Summary Update various places where ttft and itl were abbreviated but other units were not. ## Details - update metrics summary section - update metrics details section ## Test Plan Visually everything is correct, as long as tests pass it should be fine ## Related Issues - Resolves #276
2 parents f053b73 + 21b9803 commit c48c9cf

File tree

2 files changed

+13
-13
lines changed

2 files changed

+13
-13
lines changed

src/ui/lib/components/MetricsSummary/MetricsSummary.component.tsx

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -123,7 +123,7 @@ export const Component = () => {
123123
<FieldsContainer data-id="fields-container">
124124
<FieldCell data-id="field-cell-1">
125125
<Input
126-
label="TTFT (ms)"
126+
label="TIME TO FIRST TOKEN (ms)"
127127
value={ttftSLO}
128128
onChange={handleTtft}
129129
fullWidth
@@ -133,7 +133,7 @@ export const Component = () => {
133133
</FieldCell>
134134
<FieldCell data-id="field-cell-2">
135135
<Input
136-
label="ITL (ms)"
136+
label="INTER-TOKEN LATENCY (ms)"
137137
value={itlSLO}
138138
onChange={handleItl}
139139
fullWidth
@@ -212,7 +212,7 @@ export const Component = () => {
212212
</MiddleColumn>
213213
<MiddleColumn item xs={3}>
214214
<MetricValue
215-
label="TTFT"
215+
label="time to first token"
216216
value={`${formatNumber(interpolatedMetricData.ttft.enforcedPercentileValue)} ms`}
217217
match={isTtftMatch}
218218
valueColor={LineColor.Primary}
@@ -230,7 +230,7 @@ export const Component = () => {
230230
</MiddleColumn>
231231
<MiddleColumn item xs={3}>
232232
<MetricValue
233-
label="ITL"
233+
label="inter-token latency"
234234
value={`${formatNumber(interpolatedMetricData.itl.enforcedPercentileValue)} ms`}
235235
match={isItlMatch}
236236
valueColor={LineColor.Secondary}

src/ui/lib/components/WorkloadMetrics/WorkloadMetrics.component.tsx

Lines changed: 9 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -57,49 +57,49 @@ export const Component = () => {
5757
<BlockHeader label="Metrics Details" />
5858
<Box display="flex" flexDirection="row" gap={3} mt={3}>
5959
<MetricsContainer
60-
header="TTFT"
60+
header="TIME TO FIRST TOKEN"
6161
leftColumn={leftColumn(
6262
formattedRequestRate,
6363
formatNumber(ttftAtRPS.mean),
6464
'ms'
6565
)}
6666
rightColumn={columnContent(formattedRequestRate, ttftAtRPS.percentiles, 'ms')}
6767
>
68-
<GraphTitle title="TTFS vs RPS" />
68+
<GraphTitle title="Time to First Token vs RPS" />
6969
<GraphsWrapper>
7070
<DashedLine
7171
data={ttft}
7272
margins={{ left: 50, bottom: 50 }}
7373
xLegend="request per sec"
74-
yLegend="ttft (ms)"
74+
yLegend="time to first token (ms)"
7575
minX={minX}
7676
/>
7777
</GraphsWrapper>
7878
</MetricsContainer>
7979
<MetricsContainer
80-
header="ITL"
80+
header="INTER-TOKEN LATENCY"
8181
leftColumn={leftColumn3(
8282
formattedRequestRate,
8383
formatNumber(itlAtRPS.mean),
8484
'ms'
8585
)}
8686
rightColumn={columnContent(formattedRequestRate, itlAtRPS.percentiles, 'ms')}
8787
>
88-
<GraphTitle title="ITL vs RPS" />
88+
<GraphTitle title="Inter-token Latency vs RPS" />
8989
<GraphsWrapper>
9090
<DashedLine
9191
data={itl}
9292
margins={{ left: 50, bottom: 50 }}
9393
xLegend="request per sec"
94-
yLegend="itl (ms)"
94+
yLegend="inter-token latency (ms)"
9595
minX={minX}
9696
/>
9797
</GraphsWrapper>
9898
</MetricsContainer>
9999
</Box>
100100
<Box display="flex" flexDirection="row" gap={3} mt={3}>
101101
<MetricsContainer
102-
header="E2E Latency"
102+
header="Time Per Request"
103103
leftColumn={leftColumn(
104104
formattedRequestRate,
105105
formatNumber(timePerRequestAtRPS.mean),
@@ -111,13 +111,13 @@ export const Component = () => {
111111
's'
112112
)}
113113
>
114-
<GraphTitle title="E2E Latency vs RPS" />
114+
<GraphTitle title="Time Per Request vs RPS" />
115115
<GraphsWrapper>
116116
<DashedLine
117117
data={timePerRequest}
118118
margins={{ left: 50, bottom: 50 }}
119119
xLegend="request per sec"
120-
yLegend="latency (s)"
120+
yLegend="time per request (s)"
121121
minX={minX}
122122
/>
123123
</GraphsWrapper>

0 commit comments

Comments
 (0)