Skip to content

Commit c495418

Browse files
authored
update build versions in settings, workflow versioned build fix (#465)
## Summary Updating the UI build version default in settings to v4.0.0. Fixing the release tag issue. Setting the directory path with ${TAG} is not working. ## Details - prod and staging build defaults updated to v0.4.0 - release/staging workflows versioned build directory in gh-pages branch fixed ## Test Plan - Manually tested the build version updates - Trial tested the workflow change in the dev workflow to confirm methodology --- - [x] "I certify that all code in this PR is my own, except as noted below."
2 parents 094fc93 + f331e8a commit c495418

File tree

3 files changed

+8
-8
lines changed

3 files changed

+8
-8
lines changed

.github/workflows/release-candidate.yml

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -226,8 +226,8 @@ jobs:
226226
export $(grep -v '^#' .env.staging | xargs)
227227
228228
# Set asset prefix and base path with git tag
229-
ASSET_PREFIX=https://blog.vllm.ai/guidellm/ui/release/${TAG}
230-
BASE_PATH=/ui/release/${TAG}
229+
ASSET_PREFIX=https://blog.vllm.ai/guidellm/ui/${{ env.TAG }}
230+
BASE_PATH=/ui/${{ env.TAG }}
231231
GIT_SHA=${{ github.sha }}
232232
export ASSET_PREFIX=${ASSET_PREFIX}
233233
export BASE_PATH=${BASE_PATH}
@@ -239,7 +239,7 @@ jobs:
239239
with:
240240
github_token: ${{ secrets.GITHUB_TOKEN }}
241241
publish_dir: .src/ui/out
242-
destination_dir: ui/release/${TAG}
242+
destination_dir: ui/${{ env.TAG }}
243243
keep_files: false
244244
user_name: ${{ github.actor }}
245245
user_email: ${{ github.actor }}@users.noreply.github.com

.github/workflows/release.yml

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -221,8 +221,8 @@ jobs:
221221
export $(grep -v '^#' .env.production | xargs)
222222
223223
# Set asset prefix and base path with git tag
224-
ASSET_PREFIX=https://blog.vllm.ai/guidellm/ui/${TAG}
225-
BASE_PATH=/ui/${TAG}
224+
ASSET_PREFIX=https://blog.vllm.ai/guidellm/ui/${{ env.TAG }}
225+
BASE_PATH=/ui/${{ env.TAG }}
226226
GIT_SHA=${{ github.sha }}
227227
export ASSET_PREFIX=${ASSET_PREFIX}
228228
export BASE_PATH=${BASE_PATH}
@@ -234,7 +234,7 @@ jobs:
234234
with:
235235
github_token: ${{ secrets.GITHUB_TOKEN }}
236236
publish_dir: ./src/ui/out
237-
destination_dir: ui/${TAG}
237+
destination_dir: ui/${{ env.TAG }}
238238
keep_files: false
239239
user_name: ${{ github.actor }}
240240
user_email: ${{ github.actor }}@users.noreply.github.com

src/guidellm/settings.py

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -32,8 +32,8 @@ class Environment(str, Enum):
3232

3333

3434
ENV_REPORT_MAPPING = {
35-
Environment.PROD: "https://blog.vllm.ai/guidellm/ui/v0.3.1/index.html",
36-
Environment.STAGING: "https://blog.vllm.ai/guidellm/ui/release/v0.3.1/index.html",
35+
Environment.PROD: "https://blog.vllm.ai/guidellm/ui/v0.4.0/index.html",
36+
Environment.STAGING: "https://blog.vllm.ai/guidellm/ui/release/v0.4.0/index.html",
3737
Environment.DEV: "https://blog.vllm.ai/guidellm/ui/dev/index.html",
3838
Environment.LOCAL: "http://localhost:3000/index.html",
3939
}

0 commit comments

Comments
 (0)