Skip to content

Commit fbc8821

Browse files
committed
merge testing-tooling
2 parents 41345f4 + 1fc4d40 commit fbc8821

File tree

8 files changed

+18
-18
lines changed

8 files changed

+18
-18
lines changed

.gitignore

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -180,4 +180,4 @@ cython_debug/
180180
*.yaml
181181

182182
# Turn off UI related ignores, defer to ui/.gitignore
183-
!ui/**
183+
!ui/**

CONTRIBUTING.md

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -47,7 +47,7 @@ You can either clone the repository directly or fork it if you plan to contribut
4747
cd guidellm
4848
```
4949

50-
For detailed instructions on setting up your development environment, please refer to the [DEVELOPING.md](https://github.com/neuralmagic/speculators/blob/main/DEVELOPING.md) file. It includes step-by-step guidance on:
50+
For detailed instructions on setting up your development environment, please refer to the [DEVELOPING.md](https://github.com/neuralmagic/guidellm/blob/main/DEVELOPING.md) file. It includes step-by-step guidance on:
5151

5252
- Installing dependencies
5353
- Running tests
@@ -114,8 +114,8 @@ If you encounter a bug or have a feature request, please open an issue on GitHub
114114

115115
## Community Standards
116116

117-
We are committed to fostering a welcoming and inclusive community. Please read and adhere to our [Code of Conduct](https://github.com/neuralmagic/speculators/blob/main/CODE_OF_CONDUCT.md).
117+
We are committed to fostering a welcoming and inclusive community. Please read and adhere to our [Code of Conduct](https://github.com/neuralmagic/guidellm/blob/main/CODE_OF_CONDUCT.md).
118118

119119
## License
120120

121-
By contributing to Speculators, you agree that your contributions will be licensed under the [Apache License 2.0](https://github.com/neuralmagic/speculators/blob/main/LICENSE).
121+
By contributing to GuideLLM, you agree that your contributions will be licensed under the [Apache License 2.0](https://github.com/neuralmagic/guidellm/blob/main/LICENSE).

DEVELOPING.md

Lines changed: 7 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
1-
# Developing for Speculators
1+
# Developing for GuideLLM
22

3-
Thank you for your interest in contributing to Speculators! This document provides detailed instructions for setting up your development environment, implementing changes, and adhering to the project's best practices. Your contributions help us grow and improve this project.
3+
Thank you for your interest in contributing to GuideLLM! This document provides detailed instructions for setting up your development environment, implementing changes, and adhering to the project's best practices. Your contributions help us grow and improve this project.
44

55
## Setting Up Your Development Environment
66

@@ -142,7 +142,7 @@ tox
142142
To ensure your changes are covered by tests, run:
143143

144144
```bash
145-
tox -e test-unit -- --cov=speculators --cov-report=html
145+
tox -e test-unit -- --cov=guidellm --cov-report=html
146146
```
147147

148148
Review the coverage report to confirm that your new code is adequately tested.
@@ -181,7 +181,7 @@ Review the coverage report to confirm that your new code is adequately tested.
181181

182182
## Additional Resources
183183

184-
- [CONTRIBUTING.md](https://github.com/neuralmagic/speculators/blob/main/CONTRIBUTING.md): Guidelines for contributing to the project.
185-
- [CODE_OF_CONDUCT.md](https://github.com/neuralmagic/speculators/blob/main/CODE_OF_CONDUCT.md): Our expectations for community behavior.
186-
- [tox.ini](https://github.com/neuralmagic/speculators/blob/main/tox.ini): Configuration for Tox environments.
187-
- [.pre-commit-config.yaml](https://github.com/neuralmagic/speculators/blob/main/.pre-commit-config.yaml): Configuration for pre-commit hooks.
184+
- [CONTRIBUTING.md](https://github.com/neuralmagic/guidellm/blob/main/CONTRIBUTING.md): Guidelines for contributing to the project.
185+
- [CODE_OF_CONDUCT.md](https://github.com/neuralmagic/guidellm/blob/main/CODE_OF_CONDUCT.md): Our expectations for community behavior.
186+
- [tox.ini](https://github.com/neuralmagic/guidellm/blob/main/tox.ini): Configuration for Tox environments.
187+
- [.pre-commit-config.yaml](https://github.com/neuralmagic/guidellm/blob/main/.pre-commit-config.yaml): Configuration for pre-commit hooks.

README.md

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -92,7 +92,7 @@ After the evaluation is completed, GuideLLM will summarize the results into thre
9292

9393
The sections will look similar to the following: <img alt="Sample GuideLLM benchmark output" src="https://raw.githubusercontent.com/neuralmagic/guidellm/main/docs/assets/sample-output.png" />
9494

95-
For more details about the metrics and definitions, please refer to the [Metrics documentation](https://raw.githubusercontent.com/neuralmagic/guidellm/main/docs/metrics.md).
95+
For more details about the metrics and definitions, please refer to the [Metrics documentation](https://github.com/neuralmagic/guidellm/blob/main/docs/metrics.md).
9696

9797
#### 4. Explore the Results File
9898

@@ -106,7 +106,7 @@ The results from GuideLLM are used to optimize your LLM deployment for performan
106106

107107
For example, when deploying a chat application, we likely want to ensure that our time to first token (TTFT) and inter-token latency (ITL) are under certain thresholds to meet our service level objectives (SLOs) or service level agreements (SLAs). For example, setting TTFT to 200ms and ITL 25ms for the sample data provided in the example above, we can see that even though the server is capable of handling up to 13 requests per second, we would only be able to meet our SLOs for 99% of users at a request rate of 3.5 requests per second. If we relax our constraints on ITL to 50 ms, then we can meet the TTFT SLA for 99% of users at a request rate of approximately 10 requests per second.
108108

109-
For further details on determining the optimal request rate and SLOs, refer to the [SLOs documentation](https://raw.githubusercontent.com/neuralmagic/guidellm/main/docs/service_level_objectives.md).
109+
For further details on determining the optimal request rate and SLOs, refer to the [SLOs documentation](https://github.com/neuralmagic/guidellm/blob/main/docs/service_level_objectives.md).
110110

111111
### Configurations
112112

src/guidellm/__main__.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -31,7 +31,7 @@ def parse_number_str(ctx, param, value): # noqa: ARG001
3131
values = value.split(",") if "," in value else [value]
3232

3333
try:
34-
return [int(val) if val.isdigit() else float(val) for val in values]
34+
return [float(val) for val in values]
3535
except ValueError as err:
3636
raise click.BadParameter(
3737
f"{param.name} must be a number or comma-separated list of numbers."

src/guidellm/benchmark/entrypoints.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -38,7 +38,7 @@ async def benchmark_generative_text(
3838
data_args: Optional[dict[str, Any]],
3939
data_sampler: Optional[Literal["random"]],
4040
rate_type: Union[StrategyType, ProfileType],
41-
rate: Optional[Union[int, float, list[Union[int, float]]]],
41+
rate: Optional[Union[float, list[float]]],
4242
max_seconds: Optional[float],
4343
max_requests: Optional[int],
4444
warmup_percent: Optional[float],

src/guidellm/utils/random.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -37,7 +37,7 @@ def __iter__(self) -> Iterator[int]:
3737
if calc_min == calc_max:
3838
yield calc_min
3939
elif not self.variance:
40-
yield self.rng.randint(calc_min, calc_max + 1)
40+
yield self.rng.randint(calc_min, calc_max)
4141
else:
4242
rand = self.rng.gauss(self.average, self.variance)
4343
yield round(max(calc_min, min(calc_max, rand)))

tox.ini

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -66,8 +66,8 @@ description = Run link checks for root and docs markdown files
6666
deps =
6767
.[dev]
6868
commands =
69-
mkdocs-linkcheck ./
70-
mkdocs-linkcheck docs/
69+
mkdocs-linkcheck ./ --exclude 'https://github\.com/.*/blob/.*'
70+
mkdocs-linkcheck docs/ --exclude 'https://github\.com/.*/blob/.*'
7171

7272

7373
[testenv:build]

0 commit comments

Comments
 (0)