Skip to content

Commit fd85cac

Browse files
fix: final fixes
1 parent c98482f commit fd85cac

File tree

3 files changed

+3
-3
lines changed

3 files changed

+3
-3
lines changed

src/guidellm/scheduler/scheduler.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -380,7 +380,7 @@ def _add_requests(
380380
# When `--max-seconds` is set and the dataset is finite -
381381
# almost always the benchmark will end slightly before the
382382
# actual `end_time`.
383-
# Since the units are seconds, rounding 1s is reasonable.
383+
# Since the units are seconds, rounding up 1s is reasonable.
384384
if time.time() >= run_info.end_time - 1:
385385
run_info.termination_reason = "max_seconds_reached"
386386
else:

tests/e2e/test_successful_benchmark.py

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -25,7 +25,7 @@ def server():
2525

2626

2727
@pytest.mark.timeout(30)
28-
def test_max_duration_report(server: VllmSimServer):
28+
def test_max_seconds_benchmark(server: VllmSimServer):
2929
"""
3030
Another example test interacting with the server.
3131
"""
@@ -72,7 +72,7 @@ def test_max_duration_report(server: VllmSimServer):
7272

7373

7474
@pytest.mark.timeout(30)
75-
def test_max_number_report(server: VllmSimServer):
75+
def test_max_requests_benchmark(server: VllmSimServer):
7676
"""
7777
Another example test interacting with the server.
7878
"""

0 commit comments

Comments
 (0)