From c39c4bc9bbab0cdbc4bb3e332bb87436c6a00f0d Mon Sep 17 00:00:00 2001 From: Samuel Monson Date: Thu, 10 Jul 2025 11:49:20 -0400 Subject: [PATCH 1/4] Revert "Fix checkout target for pull request workflows (#212)" This reverts commit 91083695fbbc2fa95d81d95be3b6f5de415d9557. --- .github/workflows/development.yml | 21 --------------------- 1 file changed, 21 deletions(-) diff --git a/.github/workflows/development.yml b/.github/workflows/development.yml index c7d0dde7..7d49f2c1 100644 --- a/.github/workflows/development.yml +++ b/.github/workflows/development.yml @@ -12,8 +12,6 @@ jobs: python: ["3.9", "3.13"] steps: - uses: actions/checkout@v4 - with: - ref: "${{ github.event.pull_request.merge_commit_sha }}" - name: Set up Python uses: actions/setup-python@v5 with: @@ -30,8 +28,6 @@ jobs: steps: - name: Check out code uses: actions/checkout@v4 - with: - ref: "${{ github.event.pull_request.merge_commit_sha }}" - name: Install dependencies run: npm ci @@ -46,8 +42,6 @@ jobs: python: ["3.9", "3.13"] steps: - uses: actions/checkout@v4 - with: - ref: "${{ github.event.pull_request.merge_commit_sha }}" - name: Set up Python uses: actions/setup-python@v5 with: @@ -64,8 +58,6 @@ jobs: steps: - name: Check out code uses: actions/checkout@v4 - with: - ref: "${{ github.event.pull_request.merge_commit_sha }}" - name: Install dependencies run: npm ci @@ -80,8 +72,6 @@ jobs: python: ["3.9"] steps: - uses: actions/checkout@v4 - with: - ref: "${{ github.event.pull_request.merge_commit_sha }}" - name: Set up Python uses: actions/setup-python@v5 with: @@ -98,8 +88,6 @@ jobs: steps: - name: Check out code uses: actions/checkout@v4 - with: - ref: "${{ github.event.pull_request.merge_commit_sha }}" - name: Install dependencies run: npm ci @@ -114,8 +102,6 @@ jobs: python: ["3.9", "3.13"] steps: - uses: actions/checkout@v4 - with: - ref: "${{ github.event.pull_request.merge_commit_sha }}" - name: Set up Python uses: actions/setup-python@v5 with: @@ -132,8 +118,6 @@ jobs: steps: - name: Check out code uses: actions/checkout@v4 - with: - ref: "${{ github.event.pull_request.merge_commit_sha }}" - name: Install dependencies run: npm ci @@ -148,8 +132,6 @@ jobs: python: ["3.9", "3.13"] steps: - uses: actions/checkout@v4 - with: - ref: "${{ github.event.pull_request.merge_commit_sha }}" - name: Set up Python uses: actions/setup-python@v5 with: @@ -166,8 +148,6 @@ jobs: steps: - name: Check out code uses: actions/checkout@v4 - with: - ref: "${{ github.event.pull_request.merge_commit_sha }}" - name: Install dependencies run: npm ci @@ -185,7 +165,6 @@ jobs: uses: actions/checkout@v4 with: fetch-depth: 0 - ref: "${{ github.event.pull_request.merge_commit_sha }}" - name: Set up Python uses: actions/setup-python@v5 with: From 287c559f9d5dd1a78ef4aba5891ed187c83ee017 Mon Sep 17 00:00:00 2001 From: Samuel Monson Date: Thu, 10 Jul 2025 11:49:43 -0400 Subject: [PATCH 2/4] Revert "Run development workflow from target branch scope (#189)" This reverts commit fd1bf3c484ec2130871f73f41140e508640c3e0d. --- .github/workflows/development.yml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.github/workflows/development.yml b/.github/workflows/development.yml index 7d49f2c1..4928e73c 100644 --- a/.github/workflows/development.yml +++ b/.github/workflows/development.yml @@ -1,7 +1,7 @@ name: Development on: - pull_request_target: + pull_request: types: [opened, synchronize, reopened] jobs: From 270c9a044d2a6aad0fcef3f903fe18765e702dc3 Mon Sep 17 00:00:00 2001 From: Samuel Monson Date: Tue, 17 Jun 2025 15:29:35 -0400 Subject: [PATCH 3/4] Only build if the PR branch is local --- .github/workflows/development.yml | 4 ++++ 1 file changed, 4 insertions(+) diff --git a/.github/workflows/development.yml b/.github/workflows/development.yml index 4928e73c..435bf15b 100644 --- a/.github/workflows/development.yml +++ b/.github/workflows/development.yml @@ -156,6 +156,8 @@ jobs: run: npm run test:integration build: + # Only build if the PR branch is local + if: ${{ github.event.pull_request.head.repo.full_name == github.repository }} runs-on: ubuntu-latest strategy: matrix: @@ -207,6 +209,8 @@ jobs: }) build-and-push-container: + # Only build if the PR branch is local + if: ${{ github.event.pull_request.head.repo.full_name == github.repository }} runs-on: ubuntu-latest permissions: packages: write From 0ba22b8db02589f1bc0e931722319124daf1923b Mon Sep 17 00:00:00 2001 From: Samuel Monson Date: Thu, 10 Jul 2025 12:18:11 -0400 Subject: [PATCH 4/4] Apply suggestions from code review Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com> --- .github/workflows/development.yml | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/.github/workflows/development.yml b/.github/workflows/development.yml index 435bf15b..de322bcb 100644 --- a/.github/workflows/development.yml +++ b/.github/workflows/development.yml @@ -157,7 +157,7 @@ jobs: build: # Only build if the PR branch is local - if: ${{ github.event.pull_request.head.repo.full_name == github.repository }} + if: github.event.pull_request.head.repo.full_name == github.repository runs-on: ubuntu-latest strategy: matrix: @@ -210,7 +210,7 @@ jobs: build-and-push-container: # Only build if the PR branch is local - if: ${{ github.event.pull_request.head.repo.full_name == github.repository }} + if: github.event.pull_request.head.repo.full_name == github.repository runs-on: ubuntu-latest permissions: packages: write