downgrade next to fix firefox incompatibility #258
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: dalthecow <[email protected]>
|
🧹 The live preview for this PR has been removed. |
sjmonson
approved these changes
Aug 5, 2025
tjandy98
pushed a commit
to tjandy98/guidellm
that referenced
this pull request
Aug 6, 2025
## Summary The local html report was broken on firefox. There is some issue caused by Next.js. I tried many things and finally fixed it by downgrading the version from 15 to 13. Other changes in here include removing dynamic exports which have long been unneeded and were contributing to the firefox issues. Also after downgrading versions there were other things that broke that have been updated here. I'll report the issue with Next.js 15 and hopefully this can be further investigated so we can upgrade again in the future. ## Details - Remove most of the dynamic exports - Downgrade from Next.js 15.3.4 to 13.4.0. - Fix ensuing issues created by downgrade including eslint.config.js issues, change next config from .ts to .mjs, add experimental esmExternals config option, remove cypress lint config globals as they were breaking. ## Test Plan - Mostly just need to get all of the checks passing and ensure cypress tests still function. The app works in firefox now. --- "I certify that all code in this PR is my own, except as noted below." ## Use of AI None Signed-off-by: dalthecow <[email protected]> Signed-off-by: tjandy98 <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
The local html report was broken on firefox. There is some issue caused by Next.js. I tried many things and finally fixed it by downgrading the version from 15 to 13.
Other changes in here include removing dynamic exports which have long been unneeded and were contributing to the firefox issues. Also after downgrading versions there were other things that broke that have been updated here.
I'll report the issue with Next.js 15 and hopefully this can be further investigated so we can upgrade again in the future.
Details
Test Plan
"I certify that all code in this PR is my own, except as noted below."
Use of AI
None