Add a recomended extras group #313
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Samuel Monson <[email protected]>
Signed-off-by: Samuel Monson <[email protected]>
Signed-off-by: Samuel Monson <[email protected]>
sjmonson
force-pushed
the
feat/optional_deps
branch
from
2bcbd55 to
ca77be5
Compare
There was a problem hiding this comment.
Pull Request Overview
This PR adds a new Python package extras group called "recommended" that includes optional tokenizer packages for enhanced functionality. The change introduces optional dependencies for tiktoken and blobfile packages to support OpenAI tokenizer features.
- Adds a "recommended" extras group with tiktoken and blobfile dependencies
- Includes a pdm.toml configuration update for dependency management strategy
Reviewed Changes
Copilot reviewed 2 out of 3 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| pyproject.toml | Adds the "recommended" optional dependencies group with tiktoken and blobfile packages |
| pdm.toml | Adds strategy configuration for dependency updates |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
AlonKellner-RedHat
approved these changes
Sep 11, 2025
tukwila
pushed a commit
to tukwila/guidellm
that referenced
this pull request
Sep 17, 2025
## Summary <!-- Include a short paragraph of the changes introduced in this PR. If this PR requires additional context or rationale, explain why the changes are necessary. --> Adds a python extras group for recommended packages and adds a couple optional tokenizer packages to it. ## Details <!-- Provide a detailed list of all changes introduced in this pull request. --> - Adds the `recommended` package group with `tiktoken`, and `blobfile` - ~Add `default-optional-dependency-keys` field for future compatibly with PEP 771 compliant tools~ pip is picky about the key in `[project]` so reverted. Since the group name is the default I'm not sure this is even necessary. --- - [x] "I certify that all code in this PR is my own, except as noted below." ## Use of AI - [ ] Includes AI-assisted code completion - [ ] Includes code generated by an AI application - [ ] Includes AI-generated tests (NOTE: AI written tests should have a docstring that includes `## WRITTEN BY AI ##`) --------- Signed-off-by: Samuel Monson <[email protected]>
sjmonson
added a commit
that referenced
this pull request
Sep 23, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Adds a python extras group for recommended packages and adds a couple optional tokenizer packages to it.
Details
recommendedpackage group withtiktoken, andblobfileAddpip is picky about the key indefault-optional-dependency-keysfield for future compatibly with PEP 771 compliant tools[project]so reverted. Since the group name is the default I'm not sure this is even necessary.Use of AI
## WRITTEN BY AI ##)