Skip to content

Commit 7c7af39

Browse files
authored
fix rest of the minmax tests (#1469)
SUMMARY: Specify observer type for all tests to avoid future failures TEST PLAN: Test against default observer being MSE. All tests (test_min_max.py and test_mse.py) passed. ```bash (env) hzhao@janice:~/llm-compressor$ pytest -s -v tests/llmcompressor/observers/test_min_max.py ================================================ test session starts ================================================= platform linux -- Python 3.10.12, pytest-8.3.5, pluggy-1.5.0 -- /home/hzhao/llm-compressor/env/bin/python3 cachedir: .pytest_cache rootdir: /home/hzhao/llm-compressor configfile: pyproject.toml plugins: anyio-4.9.0, rerunfailures-15.0, mock-3.14.0 collected 5 items tests/llmcompressor/observers/test_min_max.py::test_min_max_observer[True-0.0078-0] 2025-05-22T17:10:01.027628-0400 | reset | INFO - Compression lifecycle reset PASSED2025-05-22T17:10:01.029926-0400 | reset | INFO - Compression lifecycle reset tests/llmcompressor/observers/test_min_max.py::test_min_max_observer[False-0.0039--128] 2025-05-22T17:10:01.030556-0400 | reset | INFO - Compression lifecycle reset PASSED2025-05-22T17:10:01.031366-0400 | reset | INFO - Compression lifecycle reset tests/llmcompressor/observers/test_min_max.py::test_min_max_observer_symmetric_scale_range 2025-05-22T17:10:01.031799-0400 | reset | INFO - Compression lifecycle reset PASSED2025-05-22T17:10:01.032502-0400 | reset | INFO - Compression lifecycle reset tests/llmcompressor/observers/test_min_max.py::test_min_max_observer_value_update 2025-05-22T17:10:01.032965-0400 | reset | INFO - Compression lifecycle reset PASSED2025-05-22T17:10:01.034333-0400 | reset | INFO - Compression lifecycle reset tests/llmcompressor/observers/test_min_max.py::test_g_idx 2025-05-22T17:10:01.034748-0400 | reset | INFO - Compression lifecycle reset PASSED2025-05-22T17:10:01.286200-0400 | reset | INFO - Compression lifecycle reset ================================================= 5 passed in 5.20s ================================================== ``` --------- Signed-off-by: shanjiaz <[email protected]>
1 parent fd71824 commit 7c7af39

File tree

2 files changed

+4
-4
lines changed

2 files changed

+4
-4
lines changed

tests/llmcompressor/observers/test_min_max.py

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -53,7 +53,7 @@ def test_min_max_observer_symmetric_scale_range():
5353
tensor *= 127
5454

5555
num_bits = 8
56-
weights = QuantizationArgs(num_bits=num_bits, symmetric=True)
56+
weights = QuantizationArgs(num_bits=num_bits, symmetric=True, observer="minmax")
5757

5858
observer = weights.observer
5959
observer = Observer.load_from_registry(observer, quantization_args=weights)
@@ -82,7 +82,7 @@ def test_min_max_observer_value_update():
8282

8383
tensor = inp
8484
num_bits = 8
85-
weights = QuantizationArgs(num_bits=num_bits, symmetric=True)
85+
weights = QuantizationArgs(num_bits=num_bits, symmetric=True, observer="minmax")
8686
observer = weights.observer
8787
observer = Observer.load_from_registry(observer, quantization_args=weights)
8888
curr_max = 1
@@ -107,7 +107,7 @@ def test_g_idx():
107107
group_size = 2
108108
input_shape = (128, 512)
109109
tensor = torch.rand(input_shape)
110-
weights = QuantizationArgs(num_bits=8, group_size=group_size)
110+
weights = QuantizationArgs(num_bits=8, group_size=group_size, observer="minmax")
111111
g_idx = make_dummy_g_idx(tensor.shape[1], group_size)
112112

113113
observer = weights.observer

tests/llmcompressor/observers/test_mse.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -46,7 +46,7 @@ def test_mse_observer_symmetric_scale_range():
4646
tensor *= 127
4747

4848
num_bits = 8
49-
weights = QuantizationArgs(num_bits=num_bits, symmetric=True)
49+
weights = QuantizationArgs(num_bits=num_bits, symmetric=True, observer="mse")
5050

5151
observer = weights.observer
5252
observer = Observer.load_from_registry(observer, quantization_args=weights)

0 commit comments

Comments
 (0)