Skip to content

Commit 85152fd

Browse files
dbarbuzzidsikka
andauthored
Replace tj-action/changed-files (#1270)
SUMMARY: Replace the use of the formerly compromised `tj-action/changed-files` action. TEST PLAN: There are a couple of runs during development of the action itself which indicate the changes behave as expected: - https://github.com/vllm-project/llm-compressor/actions/runs/13953464034 — similar to the changes in PR regarding patterns used/expected matches - https://github.com/vllm-project/llm-compressor/actions/runs/13954383262/job/39061707849 — a slightly more comprehensive test with similar patterns, but more files touched to ensure only the desired files are considered a match --------- Signed-off-by: Domenic Barbuzzi <dbarbuzz@redhat.com> Co-authored-by: Dipika Sikka <dipikasikka1@gmail.com>
1 parent 83d53e7 commit 85152fd

File tree

1 file changed

+16
-15
lines changed

1 file changed

+16
-15
lines changed

.github/workflows/test-check-transformers.yaml

Lines changed: 16 additions & 15 deletions
Original file line numberDiff line numberDiff line change
@@ -8,13 +8,13 @@ on:
88

99
env:
1010
CADENCE: "commit"
11-
11+
1212
jobs:
1313
detect-changes:
1414
runs-on: ubuntu-latest
1515

1616
outputs:
17-
changes-present: ${{ steps.changed-files.outputs.any_modified }}
17+
matched-changes: ${{ steps.changed-files.outputs.all_changed_files }}
1818

1919
steps:
2020
- name: Checkout
@@ -23,28 +23,29 @@ jobs:
2323
fetch-depth: 0
2424
- name: Get changed files
2525
id: changed-files
26-
uses: tj-actions/changed-files@v45
26+
uses: neuralmagic/nm-actions/actions/changed-files@57598f52d308d41e054b11ce9a52fc32a068ffc5 # v1.14.0
2727
with:
28-
files: |
29-
**
30-
!examples/**
31-
!tests/e2e/**
32-
!tests/lmeval/**
33-
!tests/examples/**
34-
!**/*.md
35-
!.github/**
36-
.github/workflows/test-check-transformers.yaml
28+
include-patterns: |-
29+
^src/
30+
^tests/
31+
^\.github/workflows/test-check-transformers\.yaml$
32+
^MANIFEST\.in$
33+
^setup\.py$
34+
exclude-patterns: |-
35+
^tests/e2e/
36+
^tests/lmeval/
37+
^tests/examples/
38+
\.md$
3739
3840
- name: Log relevant output
3941
run: |
40-
echo "changes-present: ${{ steps.changed-files.outputs.any_modified }}"
41-
echo "all modified files: ${{ steps.changed-files.outputs.all_modified_files }}"
42+
echo "all changed files: ${{ steps.changed-files.outputs.all_changed_files }}"
4243
shell: bash
4344

4445
transformers-tests:
4546
needs: [detect-changes]
4647
runs-on: gcp-k8s-vllm-l4-solo
47-
if: (contains(github.event.pull_request.labels.*.name, 'ready') || github.event_name == 'push') && needs.detect-changes.outputs.changes-present == 'true'
48+
if: (contains(github.event.pull_request.labels.*.name, 'ready') || github.event_name == 'push') && needs.detect-changes.outputs.matched-changes != ''
4849
steps:
4950
- uses: actions/setup-python@v5
5051
with:

0 commit comments

Comments
 (0)